Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for using a registry mirror for Docker images by introducing a new REGISTRY_MIRROR_URL environment variable. This allows users to prepend a mirror URL to image names without modifying the docker-compose.yml file or managing override files.
Changes:
- Added
REGISTRY_MIRROR_URLenvironment variable documentation in template.env - Updated image references for all ghcr.io services (mail, misp-core, misp-modules, misp-guard) to use the optional registry mirror prefix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| template.env | Adds documentation for the new REGISTRY_MIRROR_URL optional environment variable |
| docker-compose.yml | Updates four image references to support the registry mirror prefix using variable substitution with empty string default |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker supports
registry-mirroronly for Dockerhub images and not for other domains / registries. If you use a package mirror for other registries, you have to change the image name fromghcr.io/xxxxtoregistry-mirror/ghcr.io/xxxx. To avoid having to change the original docker-compose.yml or override it with a.override.ymlfile and keep the versions in sync, this change adds aREGISTRY_MIRROR_URLenv variable to specify an optional registry mirror. If not defined it defaults to an empty string resulting in the original image name.Example:
Without
REGISTRY_MIRROR_URL:With
REGISTRY_MIRROR_URL=internal.mirror.com/: