Playground comment submit & Clipboard resize#6
Open
lateefazeez wants to merge 38 commits into
Open
Conversation
lateefazeez
commented
Jul 18, 2022
lateefazeez
commented
- I implemented comment submission using cmd + enter, comment box also opens when a comment is submitted
- I resized the clipboard plugin window.
thegreatercurve
suggested changes
Jul 20, 2022
thegreatercurve
left a comment
thegreatercurve
left a comment
There was a problem hiding this comment.
@lateefazeez This is quite difficult to review. I can't see exactly what has changed compared to main as these changes still include a lot of the old code, but it's just been copied and pasted into new files, and your changes have then been made on top of these new files.
Would you mind creating a separate PR where you refactor the methods in lexical-code/src/index.ts into their own files, and then rebase this PR on top of that?
That should create 2 atomic PRs, which are a bit more readable.
* Fixed getStyleObjectFromRawCSS function to work for unformatted css strings * Testing that handles unformatted css text * Testing that $getStyleObjectFromRawCss handles unformatted css * Added TableOfContents * Renamed TableOfContetnsPlugin file name and added flow file * Added TableOfContentsPlugin to config files and added styling * Fixed types * Added TableOfContentsList as a seperate module * Fixed type of tag from string to HeadingTagType * Table of contents updates as user scrolls * Wrapped plugin in a feature * Deleted package-lock.json * Fixed conditioanl rendering syntax * Removed extra parameter * package-lock * fix imports * Update packages/lexical-playground/src/plugins/TableOfContentsPlugin.tsx Co-authored-by: Gerard Rovira <zurfyx@users.noreply.github.com> * Added sticky styling and handled text overflow * Table of contents updates automtaically on scroll without observing all heading nodes * Update table correctly when headings are not visible but exist either up or down * Fix failing E2E * Changed isTableOfContentes to showTableOfContents in settings * Added useEffect to fix memory leak * Hoisted functions that don't use props * Renamed isTableOfContets to showTableOfContents * Changing selectedHeading by observing page top * resolved lint error * Refactored scroll up logic * Added comments * Added better css * Changed place of toc div to fix failing test * Fixed adjacent headings scrolling * Fixed adjacent headings bug * Renamed helper methods * Fixed test * Added dependency array to useEffect * Added TableOfContents to dependency array * Updated dependeny array in useEffect Co-authored-by: Karam Qaoud <kqaoud@fb.com> Co-authored-by: Gerard Rovira <zurfyx@users.noreply.github.com>
* fix(lexical): calculate range selection formatting * chore: add test * chore: break the loop early when combinedFormat equals 0
* Autolink default protocol * https
* Specify the return type of getNearestNodeOfType. * return null from $getNearestNodeOfType.
* Selection.extract sfix * fix tests
* remove default styling imports on HTML paste * remove test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.