feat(tools): add MCP sampling support for server-initiated LLM requests#69
Merged
Merged
Conversation
- Advertise sampling capability in MCP initialize request - Create SamplingHandler for sampling/createMessage requests - Add per-server RPM rate limiting and loop depth prevention - Implement MCP ↔ LLM message format conversion - Wire sampling into both stdio and SSE transports - Extract shared request parsing to eliminate duplication - Comprehensive tests for conversion, rate limiting, and loop depth Fixes MLT-OSS#56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add MCP sampling capability so MCP servers can initiate LLM requests through the agent. This enables sophisticated MCP servers that need LLM completion capabilities (e.g., for agentic workflows within server tools).
Related Issue
Fixes #56
Type of Change
Changes Made
internal/tools/mcp_sampling.gointernal/tools/mcp_sampling_test.gointernal/tools/mcp.gointernal/tools/mcp_sse.goHow to Test
go build -o hermes ./cmd/hermes/go test ./internal/tools/ -v -run SamplingBuild & Test Verification
go build ./cmd/hermes/— compiles without errorsgo test ./...— all tests passgo vet ./...— no issues