Skip to content

Performance: optimize buffer handling, eliminate redundant operations, add retry limits #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Performance: optimize buffer handling, eliminate redundant operations, add retry limits #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6f4314
Initial plan
Copilot Nov 7, 2025
1c1d3de
Optimize performance: cache modules, improve string operations, reduc…
Copilot Nov 7, 2025
942f6ed
Apply same performance optimizations to docs/app.js
Copilot Nov 7, 2025
79e0742
Add retry limits and optimize buffer handling in API clients
Copilot Nov 7, 2025
da3c1d9
Add proper error handling for WebSocket send operations
Copilot Nov 7, 2025
a9be271
Add constant for byte-to-GB conversion to avoid repeated calculation
Copilot Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 89 additions & 65 deletions docs/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
let expandedContainer = null; // Only one expanded at a time
let statIntervals = {}; // Track intervals for live updates per container
let charts = {};
let actionInProgress = false; // Prevent multiple simultaneous actions

function getStatusColor(status) {
if (status && status.includes('Up') && status.includes('healthy')) return 'bg-green-200 text-green-800';
Expand All @@ -13,6 +14,40 @@ function getStatusText(status) {
return 'Stopped';
}

// Helper function to parse Docker stats
function parseDockerStats(stats) {
let cpu = 0, ram = 0, ramTotal = 1, rx = 0, tx = 0;

// CPU calculation
if (stats.cpu_stats && stats.precpu_stats) {
const cpuDelta = stats.cpu_stats.cpu_usage.total_usage - stats.precpu_stats.cpu_usage.total_usage;
const sysDelta = stats.cpu_stats.system_cpu_usage - stats.precpu_stats.system_cpu_usage;
const cpuCount = stats.cpu_stats.online_cpus || 1;
if (cpuDelta > 0 && sysDelta > 0) {
cpu = ((cpuDelta / sysDelta) * cpuCount * 100);
}
}

// Memory calculation
if (stats.memory_stats && stats.memory_stats.usage) {
ram = stats.memory_stats.usage / (1024 * 1024 * 1024);
ramTotal = stats.memory_stats.limit / (1024 * 1024 * 1024);
}

// Network calculation
if (stats.networks) {
let totalRx = 0, totalTx = 0;
Object.values(stats.networks).forEach(nw => {
totalRx += nw.rx_bytes || 0;
totalTx += nw.tx_bytes || 0;
});
rx = totalRx / 1024;
tx = totalTx / 1024;
}

return { cpu, ram, ramTotal, rx, tx };
}

function stopStatsUpdates(id) {
if (statIntervals[id]) {
clearInterval(statIntervals[id]);
Expand Down Expand Up @@ -96,13 +131,20 @@ window.expandContainer = function(id) {
};

window.containerAction = function(id, action) {
if (actionInProgress) {
return; // Prevent multiple simultaneous actions
}
actionInProgress = true;
fetch(`/api/containers/${id}/${action}`, { method: 'POST' })
.then(res => res.json())
.then(() => {
fetchStatsAndRender();
alert(`Action ${action} on container ${id} successful!`);
})
.catch(err => alert(`Failed to ${action}: ${err}`));
.catch(err => alert(`Failed to ${action}: ${err}`))
.finally(() => {
actionInProgress = false;
});
};

function startStatsUpdates(id) {
Expand All @@ -111,74 +153,56 @@ function startStatsUpdates(id) {
// history for chart
let cpuH=[], ramH=[], netH=[];
async function pollStats() {
// poll stats
const res = await fetch(`/api/containers/${id}/stats`);
const stats = await res.json();
// Parse stats (your Docker parse logic as before)
let cpu = 0, ram=0, ramTotal=1, rx=0, tx=0;
try {
if (stats.cpu_stats && stats.precpu_stats) {
const cpuDelta = stats.cpu_stats.cpu_usage.total_usage - stats.precpu_stats.cpu_usage.total_usage;
const sysDelta = stats.cpu_stats.system_cpu_usage - stats.precpu_stats.system_cpu_usage;
const cpuCount = stats.cpu_stats.online_cpus || 1;
if (cpuDelta > 0 && sysDelta > 0) {
cpu = ((cpuDelta / sysDelta) * cpuCount * 100);
}
}
if (stats.memory_stats && stats.memory_stats.usage) {
ram = stats.memory_stats.usage / 1024 / 1024 / 1024;
ramTotal = stats.memory_stats.limit / 1024 / 1024 / 1024;
}
if (stats.networks) {
let totalRx = 0, totalTx = 0;
Object.values(stats.networks).forEach(nw => {
totalRx += nw.rx_bytes || 0;
totalTx += nw.tx_bytes || 0;
});
rx = totalRx / 1024;
tx = totalTx / 1024;
}
} catch(e) {}
// poll stats
const res = await fetch(`/api/containers/${id}/stats`);
const stats = await res.json();

// Parse stats using helper function
const { cpu, ram, ramTotal, rx, tx } = parseDockerStats(stats);

// keep short history
cpuH.push(cpu); if (cpuH.length>15) cpuH.shift();
ramH.push(ram); if (ramH.length>15) ramH.shift();
netH.push(rx); if (netH.length>15) netH.shift();
// keep short history
cpuH.push(cpu); if (cpuH.length>15) cpuH.shift();
ramH.push(ram); if (ramH.length>15) ramH.shift();
netH.push(rx); if (netH.length>15) netH.shift();

// Update stats UI
const cpuEL = document.getElementById(`cpu-${id}`);
const ramEL = document.getElementById(`ram-${id}`);
const netEL = document.getElementById(`net-${id}`);
if(cpuEL) cpuEL.textContent = `${cpu.toFixed(1)}%`;
if(ramEL) ramEL.textContent = `${ram.toFixed(2)} / ${ramTotal.toFixed(2)} GB`;
if(netEL) netEL.textContent = `↑ ${rx.toFixed(1)} KB/s ↓ ${tx.toFixed(1)} KB/s`;
// Update stats UI
const cpuEL = document.getElementById(`cpu-${id}`);
const ramEL = document.getElementById(`ram-${id}`);
const netEL = document.getElementById(`net-${id}`);
if(cpuEL) cpuEL.textContent = `${cpu.toFixed(1)}%`;
if(ramEL) ramEL.textContent = `${ram.toFixed(2)} / ${ramTotal.toFixed(2)} GB`;
if(netEL) netEL.textContent = `↑ ${rx.toFixed(1)} KB/s ↓ ${tx.toFixed(1)} KB/s`;

// Render charts (handle repeated creation)
if(!charts[id]) {
charts[id] = {
cpu: new Chart(document.getElementById(`cpuChart-${id}`), {
type: 'line',
data: { labels:Array(cpuH.length).fill(''), datasets:[{label:"CPU",data:cpuH,borderColor:"#3b82f6",backgroundColor:"rgba(59,130,246,.11)",fill:true,tension:.45}] },
options: {responsive:true, plugins:{legend:{display:false}}, scales:{x:{display:false},y:{display:false,min:0,max:100}}}
}),
ram: new Chart(document.getElementById(`ramChart-${id}`), {
type: 'line',
data: { labels:Array(ramH.length).fill(''), datasets:[{label:"RAM",data:ramH,borderColor:"#10b981",backgroundColor:"rgba(16,185,129,.15)",fill:true,tension:.45}] },
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
net: new Chart(document.getElementById(`netChart-${id}`), {
type: 'line',
data:{labels:Array(netH.length).fill(''),datasets:[{label:"NET",data:netH,borderColor:"#fde047",backgroundColor:"rgba(250,204,21,.09)",fill:true,tension:.45}]},
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
};
} else {
charts[id].cpu.data.datasets[0].data = cpuH;
charts[id].cpu.update('none');
charts[id].ram.data.datasets[0].data = ramH;
charts[id].ram.update('none');
charts[id].net.data.datasets[0].data = netH;
charts[id].net.update('none');
// Render charts (handle repeated creation)
if(!charts[id]) {
charts[id] = {
cpu: new Chart(document.getElementById(`cpuChart-${id}`), {
type: 'line',
data: { labels:Array(cpuH.length).fill(''), datasets:[{label:"CPU",data:cpuH,borderColor:"#3b82f6",backgroundColor:"rgba(59,130,246,.11)",fill:true,tension:.45}] },
options: {responsive:true, plugins:{legend:{display:false}}, scales:{x:{display:false},y:{display:false,min:0,max:100}}}
}),
ram: new Chart(document.getElementById(`ramChart-${id}`), {
type: 'line',
data: { labels:Array(ramH.length).fill(''), datasets:[{label:"RAM",data:ramH,borderColor:"#10b981",backgroundColor:"rgba(16,185,129,.15)",fill:true,tension:.45}] },
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
net: new Chart(document.getElementById(`netChart-${id}`), {
type: 'line',
data:{labels:Array(netH.length).fill(''),datasets:[{label:"NET",data:netH,borderColor:"#fde047",backgroundColor:"rgba(250,204,21,.09)",fill:true,tension:.45}]},
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
};
} else {
charts[id].cpu.data.datasets[0].data = cpuH;
charts[id].cpu.update('none');
charts[id].ram.data.datasets[0].data = ramH;
charts[id].ram.update('none');
charts[id].net.data.datasets[0].data = netH;
charts[id].net.update('none');
}
} catch(e) {
console.error('Error polling stats:', e);
}
}
pollStats(); // initial
Expand Down
154 changes: 89 additions & 65 deletions public/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
let expandedContainer = null; // Only one expanded at a time
let statIntervals = {}; // Track intervals for live updates per container
let charts = {};
let actionInProgress = false; // Prevent multiple simultaneous actions

function getStatusColor(status) {
if (status && status.includes('Up') && status.includes('healthy')) return 'bg-green-200 text-green-800';
Expand All @@ -13,6 +14,40 @@ function getStatusText(status) {
return 'Stopped';
}

// Helper function to parse Docker stats
function parseDockerStats(stats) {
let cpu = 0, ram = 0, ramTotal = 1, rx = 0, tx = 0;

// CPU calculation
if (stats.cpu_stats && stats.precpu_stats) {
const cpuDelta = stats.cpu_stats.cpu_usage.total_usage - stats.precpu_stats.cpu_usage.total_usage;
const sysDelta = stats.cpu_stats.system_cpu_usage - stats.precpu_stats.system_cpu_usage;
const cpuCount = stats.cpu_stats.online_cpus || 1;
if (cpuDelta > 0 && sysDelta > 0) {
cpu = ((cpuDelta / sysDelta) * cpuCount * 100);
}
}

// Memory calculation
if (stats.memory_stats && stats.memory_stats.usage) {
ram = stats.memory_stats.usage / (1024 * 1024 * 1024);
ramTotal = stats.memory_stats.limit / (1024 * 1024 * 1024);
}

// Network calculation
if (stats.networks) {
let totalRx = 0, totalTx = 0;
Object.values(stats.networks).forEach(nw => {
totalRx += nw.rx_bytes || 0;
totalTx += nw.tx_bytes || 0;
});
rx = totalRx / 1024;
tx = totalTx / 1024;
}

return { cpu, ram, ramTotal, rx, tx };
}

function stopStatsUpdates(id) {
if (statIntervals[id]) {
clearInterval(statIntervals[id]);
Expand Down Expand Up @@ -96,13 +131,20 @@ window.expandContainer = function(id) {
};

window.containerAction = function(id, action) {
if (actionInProgress) {
return; // Prevent multiple simultaneous actions
}
actionInProgress = true;
fetch(`/api/containers/${id}/${action}`, { method: 'POST' })
.then(res => res.json())
.then(() => {
fetchStatsAndRender();
alert(`Action ${action} on container ${id} successful!`);
})
.catch(err => alert(`Failed to ${action}: ${err}`));
.catch(err => alert(`Failed to ${action}: ${err}`))
.finally(() => {
actionInProgress = false;
});
};

function startStatsUpdates(id) {
Expand All @@ -111,74 +153,56 @@ function startStatsUpdates(id) {
// history for chart
let cpuH=[], ramH=[], netH=[];
async function pollStats() {
// poll stats
const res = await fetch(`/api/containers/${id}/stats`);
const stats = await res.json();
// Parse stats (your Docker parse logic as before)
let cpu = 0, ram=0, ramTotal=1, rx=0, tx=0;
try {
if (stats.cpu_stats && stats.precpu_stats) {
const cpuDelta = stats.cpu_stats.cpu_usage.total_usage - stats.precpu_stats.cpu_usage.total_usage;
const sysDelta = stats.cpu_stats.system_cpu_usage - stats.precpu_stats.system_cpu_usage;
const cpuCount = stats.cpu_stats.online_cpus || 1;
if (cpuDelta > 0 && sysDelta > 0) {
cpu = ((cpuDelta / sysDelta) * cpuCount * 100);
}
}
if (stats.memory_stats && stats.memory_stats.usage) {
ram = stats.memory_stats.usage / 1024 / 1024 / 1024;
ramTotal = stats.memory_stats.limit / 1024 / 1024 / 1024;
}
if (stats.networks) {
let totalRx = 0, totalTx = 0;
Object.values(stats.networks).forEach(nw => {
totalRx += nw.rx_bytes || 0;
totalTx += nw.tx_bytes || 0;
});
rx = totalRx / 1024;
tx = totalTx / 1024;
}
} catch(e) {}
// poll stats
const res = await fetch(`/api/containers/${id}/stats`);
const stats = await res.json();

// Parse stats using helper function
const { cpu, ram, ramTotal, rx, tx } = parseDockerStats(stats);

// keep short history
cpuH.push(cpu); if (cpuH.length>15) cpuH.shift();
ramH.push(ram); if (ramH.length>15) ramH.shift();
netH.push(rx); if (netH.length>15) netH.shift();
// keep short history
cpuH.push(cpu); if (cpuH.length>15) cpuH.shift();
ramH.push(ram); if (ramH.length>15) ramH.shift();
netH.push(rx); if (netH.length>15) netH.shift();

// Update stats UI
const cpuEL = document.getElementById(`cpu-${id}`);
const ramEL = document.getElementById(`ram-${id}`);
const netEL = document.getElementById(`net-${id}`);
if(cpuEL) cpuEL.textContent = `${cpu.toFixed(1)}%`;
if(ramEL) ramEL.textContent = `${ram.toFixed(2)} / ${ramTotal.toFixed(2)} GB`;
if(netEL) netEL.textContent = `↑ ${rx.toFixed(1)} KB/s ↓ ${tx.toFixed(1)} KB/s`;
// Update stats UI
const cpuEL = document.getElementById(`cpu-${id}`);
const ramEL = document.getElementById(`ram-${id}`);
const netEL = document.getElementById(`net-${id}`);
if(cpuEL) cpuEL.textContent = `${cpu.toFixed(1)}%`;
if(ramEL) ramEL.textContent = `${ram.toFixed(2)} / ${ramTotal.toFixed(2)} GB`;
if(netEL) netEL.textContent = `↑ ${rx.toFixed(1)} KB/s ↓ ${tx.toFixed(1)} KB/s`;

// Render charts (handle repeated creation)
if(!charts[id]) {
charts[id] = {
cpu: new Chart(document.getElementById(`cpuChart-${id}`), {
type: 'line',
data: { labels:Array(cpuH.length).fill(''), datasets:[{label:"CPU",data:cpuH,borderColor:"#3b82f6",backgroundColor:"rgba(59,130,246,.11)",fill:true,tension:.45}] },
options: {responsive:true, plugins:{legend:{display:false}}, scales:{x:{display:false},y:{display:false,min:0,max:100}}}
}),
ram: new Chart(document.getElementById(`ramChart-${id}`), {
type: 'line',
data: { labels:Array(ramH.length).fill(''), datasets:[{label:"RAM",data:ramH,borderColor:"#10b981",backgroundColor:"rgba(16,185,129,.15)",fill:true,tension:.45}] },
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
net: new Chart(document.getElementById(`netChart-${id}`), {
type: 'line',
data:{labels:Array(netH.length).fill(''),datasets:[{label:"NET",data:netH,borderColor:"#fde047",backgroundColor:"rgba(250,204,21,.09)",fill:true,tension:.45}]},
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
};
} else {
charts[id].cpu.data.datasets[0].data = cpuH;
charts[id].cpu.update('none');
charts[id].ram.data.datasets[0].data = ramH;
charts[id].ram.update('none');
charts[id].net.data.datasets[0].data = netH;
charts[id].net.update('none');
// Render charts (handle repeated creation)
if(!charts[id]) {
charts[id] = {
cpu: new Chart(document.getElementById(`cpuChart-${id}`), {
type: 'line',
data: { labels:Array(cpuH.length).fill(''), datasets:[{label:"CPU",data:cpuH,borderColor:"#3b82f6",backgroundColor:"rgba(59,130,246,.11)",fill:true,tension:.45}] },
options: {responsive:true, plugins:{legend:{display:false}}, scales:{x:{display:false},y:{display:false,min:0,max:100}}}
}),
ram: new Chart(document.getElementById(`ramChart-${id}`), {
type: 'line',
data: { labels:Array(ramH.length).fill(''), datasets:[{label:"RAM",data:ramH,borderColor:"#10b981",backgroundColor:"rgba(16,185,129,.15)",fill:true,tension:.45}] },
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
net: new Chart(document.getElementById(`netChart-${id}`), {
type: 'line',
data:{labels:Array(netH.length).fill(''),datasets:[{label:"NET",data:netH,borderColor:"#fde047",backgroundColor:"rgba(250,204,21,.09)",fill:true,tension:.45}]},
options:{responsive:true,plugins:{legend:{display:false}},scales:{x:{display:false},y:{display:false,min:0}}}
}),
};
} else {
charts[id].cpu.data.datasets[0].data = cpuH;
charts[id].cpu.update('none');
charts[id].ram.data.datasets[0].data = ramH;
charts[id].ram.update('none');
charts[id].net.data.datasets[0].data = netH;
charts[id].net.update('none');
}
} catch(e) {
console.error('Error polling stats:', e);
}
}
pollStats(); // initial
Expand Down
5 changes: 3 additions & 2 deletions server/docker/engineClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ function dockerRequest(path, method = 'GET') {
timeout,
};
const req = http.request(options, res => {
let data = '';
res.on('data', chunk => data += chunk);
const chunks = [];
res.on('data', chunk => chunks.push(chunk));
res.on('end', () => {
const data = Buffer.concat(chunks).toString();
try {
resolve({ status: res.statusCode, data: JSON.parse(data) });
} catch {
Expand Down
Loading