Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
Author
|
Error was not due to change in CI environment as first hypothesized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3374 has a lot of test failures; some look like bugs that I need to look into, others look like floating-point imprecision. Purpose of this PR is to see if failures in the CI environment are wholly independent of the changes on #3374.
I think I saw somewhere that one of the two major compilers has changed with one of their major version updates the default floating-point precision flag, which has a chance of being supra-threshold for some of our tests (though I'd have expected the Mac CI tests to have already triggered them; maybe x86 has a different low-precision mode to ARM?)