Skip to content

Address C++14 compilation warnings - #3409

Merged
Lestropie merged 3 commits into
masterfrom
compiler_warnings_cpp14
Jul 3, 2026
Merged

Address C++14 compilation warnings#3409
Lestropie merged 3 commits into
masterfrom
compiler_warnings_cpp14

Conversation

@Lestropie

Copy link
Copy Markdown
Member

These surfaced in the new Eigen 5.0.0 CI workflow check in #3341, but are unrelated to the content of that PR.

Result of #3403. Looks like the workflow actually failed there but it didn't prevent addition to the merge queue?

@Lestropie

Copy link
Copy Markdown
Member Author

Compiler updates have led to CI failing at the configure stage on master due to Clang on Mac flagging impermissible function names in JSON for Modern C++. Given this PR is already about fixing CI on master, have integrated an update to that dependency here.

@Lestropie
Lestropie requested a review from a team July 2, 2026 05:29
@Lestropie

Copy link
Copy Markdown
Member Author

@MRtrix3/mrtrix3-devs Can I please get a review to fix CI on master.

Comment thread cmd/transformcalc.cpp
@Lestropie
Lestropie added this pull request to the merge queue Jul 3, 2026
Merged via the queue into master with commit 03a8c7b Jul 3, 2026
6 checks passed
@Lestropie
Lestropie deleted the compiler_warnings_cpp14 branch July 3, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants