Skip to content

More GameEventUserValueTypes#659

Merged
Zintixx merged 2 commits intoMS2Community:masterfrom
Zintixx:gameeventuservaluetypes
Feb 24, 2026
Merged

More GameEventUserValueTypes#659
Zintixx merged 2 commits intoMS2Community:masterfrom
Zintixx:gameeventuservaluetypes

Conversation

@Zintixx
Copy link
Copy Markdown
Collaborator

@Zintixx Zintixx commented Feb 24, 2026

Summary by CodeRabbit

  • New Features
    • Added comprehensive support for multiple new in-game events including snowman-themed seasonal activities, couple dance mechanics, and item collection challenges with integrated reward tracking.
    • Enhanced attendance recognition and returning player engagement tracking capabilities.
    • Expanded event infrastructure to support additional player progression mechanics.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bb0fc9 and 5ac7330.

📒 Files selected for processing (1)
  • Maple2.Model/Enum/GameEventUserValueType.cs

📝 Walkthrough

Walkthrough

This change extends the GameEventUserValueType enum by adding 9 new members across multiple event categories: Attendance (AttendanceNear), general user tracking (ReturnUser), Snowman Event tracking (4 values), Couple Dance mechanics (2 values), and a CollectItemGroup flag.

Changes

Cohort / File(s) Summary
GameEventUserValueType Enum
Maple2.Model/Enum/GameEventUserValueType.cs
Added 9 new enum members: AttendanceNear (105), ReturnUser (320), SnowflakeCount (1700), DailyCompleteCount (1701), AccumCompleteCount (1702), AccumCompleteRewardReceived (1703), CoupleDanceBannerOpen (2100), CoupleDanceRewardState (2101), and CollectItemGroup (2200). Includes inline comment on AttendanceRewardsClaimed (102).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Nine new values, hopping into place,
From snowflakes to dances, a festive race,
Enum members multiplied with pride,
Event tracking opens nice and wide! ❄️💃

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Zintixx Zintixx merged commit 0d7c586 into MS2Community:master Feb 24, 2026
@Zintixx Zintixx deleted the gameeventuservaluetypes branch February 24, 2026 06:08
@coderabbitai coderabbitai bot mentioned this pull request Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant