Test endianness with compiler built-in#175
Closed
bgermann wants to merge 1 commit intoMacPaw:masterfrom
Closed
Conversation
There is no definition for XAD_BYTE_ORDER_BIG_ENDIAN, so big endian machines will use the little endian CRC implementation. Use compiler built-ins to check for endianness instead. Fixes: MacPaw#168
bgermann
force-pushed
the
fix/crc-big-endian
branch
from
2bcaf76 to
ed3141f
Compare
Contributor
Author
|
If you do not want to use the compiler built-ins this is probably okay by looking at the source. |
Contributor
|
Duplicated in the #179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no definition for XAD_BYTE_ORDER_BIG_ENDIAN, so big endian machines will use the little endian CRC implementation. Use compiler built-ins to check for endianness instead.
Fixes: #168