Backport changes to properly hide non-interface functions #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git describe --tags --abbrev=8in OpenBLAS at theOPENBLAS_COMMIT. If I did not updateOPENBLAS_COMMIT, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)Should solve numpy/numpy#30299
Backport the changes from #241 to v0.3.30.0.8, which will become v0.3.30.0.9. Note we define
NO_LAPACKE=1so we no longer export the scipy_LAPACKE_* functions likescipy_LAPACKE_cgelqf64_, just the scipy_ ones likescipy_cgelqf_64_. I don't see either SciPy nor NumPy using theLAPACKEinterfaces.