Add mul_depth control and final RingGSW decryption error logging#126
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e25d83c1a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,5 @@ | |||
| data_no,protocol,implementation,test_target,security_bits,input_count,input_size,injector_batch_bits,output_size,ring_dim_config,min_log_ring_dim,max_log_ring_dim,selected_log_ring_dim,selected_ring_dim,min_crt_depth,max_crt_depth,selected_crt_depth,crt_bits,base_bits,p_moduli_bits,max_unreduced_muls,scale,noise_refresh_cbd_n,error_sigma,trapdoor_sigma,d_secret,bench_iterations,search_only,lattice_estimator_check,lattice_reference_gauss_secpar,lattice_reference_cbd_secpar,lattice_reference_log_file,max_prf_mask_output_coeff_bits,achieved_secpar_for_gauss_in_run,achieved_secpar_for_cbd_in_run,prf_mask_output_coeff_bits,noise_refresh_v_bits,final_seed_bits,noisy_plaintext_error_bits,input_injection_error_bits,git_commit,git_worktree_dirty,simulation_log_file,benchmark_estimation_git_commit,benchmark_estimation_bench_iterations,benchmark_estimation_log_file,benchmark_estimation_obfuscate_latency,benchmark_estimation_obfuscate_total_time_nanos,benchmark_estimation_obfuscate_max_parallelism,benchmark_estimation_eval_latency,benchmark_estimation_eval_total_time_nanos,benchmark_estimation_eval_max_parallelism,benchmark_estimation_obfuscate_input_injection_latency_percent,benchmark_estimation_obfuscate_input_injection_total_time_percent,benchmark_estimation_eval_input_injection_latency_percent,benchmark_estimation_eval_input_injection_total_time_percent,benchmark_estimation_obfuscated_circuit_bytes,benchmark_estimation_input_injection_bytes | |||
| 1,DiamondIO,tests/test_gpu_diamond_io.rs,test_gpu_diamond_io_error_search_and_bench_estimate,100,10,100,10,6,65536,15,17,16,65536,45,55,53,28,14,7,4,256,2,4.0,4.578,1,1,true,measured,120,120,/home/sora/.codex/worktrees/cedf/mxx/logs/test_gpu_diamond_io_input100_batch10_crt45_55_log15_17_sec100_sigma4p0_cbd2_release.log,1540,120,120,1474,756,149531758,1274,512,7bab63d0dcb8e75cd41cb9a140f49b19fb0a093f,true,/home/sora/.codex/worktrees/cedf/mxx/logs/test_gpu_diamond_io_input100_batch10_crt45_55_log15_17_sec100_sigma4p0_cbd2_release.log,d5ade121f9f09eafa4faa2f9cae1bb6e8dfbb7d8,5,/workspace/logs/diamond_io_sec100_h200_iter5_d5ade121_20260517T070013JST/mxx-h200-diamond-io-sec100-est-20260517_1gpu_d5ade121f9f0_20260517T070013JST_diamond_io_row1.log,6116.0162626537995,4147712288836272546518676036861137818135063392704860629750,24170928207324098131482568296628771565212991810,2081.6366215446014,350048464264823037952904676103997678563435289528,10760822874598810008199153238566502400,0.8956872261884774,1.0219173976262904e-57,2.6697915314711547,9.47236296456918e-55,7485461781551070670753632832559405143329441533839620640,718912573794748064 | |||
There was a problem hiding this comment.
The repository guideline in AGENTS.md says documented file paths must be relative to the repo root, but these committed rows record machine-specific absolute paths such as /home/sora/... and /workspace/logs/.... Since bench/check_diamond_io_csv_logs.py defaults to this CSV, a fresh checkout cannot use the committed data without reproducing the original author's filesystem layout or relying on filename-only fallbacks; store these log references relative to the repo (for example under logs/...) instead.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LWE_NESTED_RNS_RING_GSW_MUL_BENCH_MUL_DEPTHwith a default of1.lhs * rhs * rhs * ...for the configured depth.infoand includedmul_depthin the circuit config logging.Testing
cargo +nightly fmt --allFIDESLIB_SKIP_SUBMODULE_UPDATE=1 cargo test --features gpu --test test_gpu_lwe_nested_rns_ring_gsw_mul_bench --no-runFIDESLIB_SKIP_SUBMODULE_UPDATE=1 cargo test --release --features gpu --test test_gpu_lwe_nested_rns_ring_gsw_mul_bench --no-runmul_depth=1,2, and3withmin_crt_depth=max_crt_depth=53completed far enough to capture the requested metrics before later GPU-memory failures in auxiliary sampling estimation.