Add security parameter check by lattice estimator to the WE integration test#129
Conversation
SoraSuegami
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d94f3a8a25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| candidate.injector.params.clone() | ||
| }, | ||
| ) else { | ||
| return None; |
There was a problem hiding this comment.
When lattice checking is enabled for a ring-dimension range, this early return None makes the whole CRT-depth search fail as soon as max_crt_depth is insecure for all allowed ring dimensions. Security decreases as the CRT modulus grows, so a smaller CRT depth may still satisfy both the Gaussian security check and the q/4 correctness margin; the search should not discard those lower depths just because the initial upper-bound probe is insecure.
Useful? React with 👍 / 👎.
1 participant
No description provided.