Skip to content

Refine Diamond benchmark estimation and input-injection accounting#130

Merged
SoraSuegami merged 6 commits into
mainfrom
codex/fix-benchmark-estimator-0608
Jun 9, 2026
Merged

Refine Diamond benchmark estimation and input-injection accounting#130
SoraSuegami merged 6 commits into
mainfrom
codex/fix-benchmark-estimator-0608

Conversation

@SoraSuegami

Copy link
Copy Markdown
Member

Summary

  • Split shared input-injection benchmark logic into a dedicated estimator and reuse it from Diamond iO and Diamond WE
  • Remove compatibility-only constructors and make the test scaffolding construct explicit unit-cost inputs
  • Add missing artifact decode, materialization, and serialization costs so benchmark estimates better match the CPU and GPU execution paths
  • Clean up related simulation code and GPU test coverage to keep the estimator and runtime paths aligned

Testing

  • cargo +nightly fmt --all
  • cargo check
  • cargo test --lib diamond_we_bench_estimate
  • cargo check --features gpu

@SoraSuegami SoraSuegami marked this pull request as ready for review June 9, 2026 14:59
@SoraSuegami SoraSuegami merged commit a5b4868 into main Jun 9, 2026
3 checks passed
@SoraSuegami SoraSuegami deleted the codex/fix-benchmark-estimator-0608 branch June 9, 2026 14:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review


P1 Badge Keep generated artifacts out of references

AGENTS.md states that directories named references are read-only for humans/agents to consult and that agents must never edit them. This commit adds references/diamond_io.pdf, so an agent-produced change with this file violates the repository workflow; please remove it from the patch or place the artifact somewhere outside references.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant