Skip to content

Logging: cast enums to int for fmt 12 format calls#158

Merged
Segfaultd merged 2 commits into
masterfrom
update-spdlog-fmt
Jun 15, 2026
Merged

Logging: cast enums to int for fmt 12 format calls#158
Segfaultd merged 2 commits into
masterfrom
update-spdlog-fmt

Conversation

@Segfaultd

Copy link
Copy Markdown
Member

fmt 12 (from the Framework spdlog/fmt vendored upgrade) no longer implicitly formats enums. Cast the menu event, district id, and entity type args in the client log/format calls to int, matching prior fmt 8 behavior.

fmt 12 (from the Framework spdlog/fmt vendored upgrade) no longer implicitly formats enums. Cast the menu event, district id, and entity type args in the client log/format calls to int, matching prior fmt 8 behavior.
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@Segfaultd, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 26 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 23178707-f30a-4a99-8718-79d406829b33

📥 Commits

Reviewing files that changed from the base of the PR and between 64535f6 and d2c1fba.

📒 Files selected for processing (3)
  • code/client/src/core/hooks/hud.cpp
  • code/client/src/core/hooks/navigation.cpp
  • code/client/src/core/ui/devs/entity_browser.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update-spdlog-fmt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Segfaultd Segfaultd merged commit aef40c2 into master Jun 15, 2026
1 check was pending
@Segfaultd Segfaultd deleted the update-spdlog-fmt branch June 15, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants