CodeQL cleanup for alerts #18, #19, #20#4153
Merged
Merged
Conversation
Remove dead local debug helper in calendar e2e spec to resolve CodeQL alert #20.
khassel
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup PR to close three CodeQL alerts, without changing app behavior.
js/loader.jsjs/socketclient.jstests/electron/modules/calendar_spec.jsFor
LoaderandMMSocket, make the global export explicit viaglobalThis(instead of suppressingno-unused-vars).For calendar tests, remove the unused debug helper
logAllText.Also includes a tiny e2e cleanup:
MM_PORTis cleared inafterAll.Outcome: Three open CodeQL alerts are addressed with small, low-risk changes. The global intent for
LoaderandMMSocketis explicit, dead test helper code is removed, and e2e test state is cleaned up more reliably between runs.With this, all current code scanning issues should be resolved in the develop branch 🎈