Skip to content

293 implement dust attempt2#295

Merged
ThomasCeulemans merged 9 commits intostablefrom
293-implement-dust-attempt2
Oct 29, 2025
Merged

293 implement dust attempt2#295
ThomasCeulemans merged 9 commits intostablefrom
293-implement-dust-attempt2

Conversation

@ThomasCeulemans
Copy link
Collaborator

Contains basic continuum/dust implementation; required input is grid of opacities at given frequencies.

Features:

  • can now specify a dust/continuum opacity at each position, frequency; and specify the dust temperature at each position
  • automated test (NOTE: without velocity gradient) for the expected intensity/optical depth given only dust present.
  • freely choose the frequency grid to use for imaging using model.set_custom_spectral_discretization (using Pybind to get the frequency grid directly from python)

It seems that the dust implementation causes no significant performance regressions (tested on vanZadelhoff benchmarks), so no different compile options are needed.

This branch should fix issue #293.

@ThomasCeulemans ThomasCeulemans self-assigned this Oct 3, 2025
@ThomasCeulemans ThomasCeulemans linked an issue Oct 3, 2025 that may be closed by this pull request
@ThomasCeulemans
Copy link
Collaborator Author

Evidently, I still forgot to write any extra (not in c++ code) documentation. Ah well, this should be a reminder for me to actually do this and add an extra example to the documentation, or make an extra issue.

@ThomasCeulemans
Copy link
Collaborator Author

With the latest commit, issue #294 should be fixed.

@ThomasCeulemans ThomasCeulemans linked an issue Oct 17, 2025 that may be closed by this pull request
4 tasks
@ThomasCeulemans
Copy link
Collaborator Author

Ah right, conda randomly decided to break CI procedures by adding tos confirmation on their command line interface... Well for unknown reasons the macos build still works fine, while the ubunu one hangs. Ah well, I'm confident that the linux build still works either way.

@ThomasCeulemans ThomasCeulemans merged commit e251968 into stable Oct 29, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modifications needed to interpolation criterion Including dust in Magritte

2 participants