Merged
Conversation
…acity files from jena database; NOTE: no changes yet to the c++ code
…vers, continuum test script.
…radient. TODO: check for performance regression
Collaborator
Author
|
Evidently, I still forgot to write any extra (not in c++ code) documentation. Ah well, this should be a reminder for me to actually do this and add an extra example to the documentation, or make an extra issue. |
…e/Magritte into 293-implement-dust-attempt2
… for dust/continuum.
Collaborator
Author
|
With the latest commit, issue #294 should be fixed. |
4 tasks
Collaborator
Author
|
Ah right, conda randomly decided to break CI procedures by adding tos confirmation on their command line interface... Well for unknown reasons the macos build still works fine, while the ubunu one hangs. Ah well, I'm confident that the linux build still works either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains basic continuum/dust implementation; required input is grid of opacities at given frequencies.
Features:
model.set_custom_spectral_discretization(using Pybind to get the frequency grid directly from python)It seems that the dust implementation causes no significant performance regressions (tested on vanZadelhoff benchmarks), so no different compile options are needed.
This branch should fix issue #293.