fix: Add validation for hand decomposition#190
Merged
Nihisil merged 10 commits intoMahjongRepository:masterfrom Feb 7, 2026
Merged
fix: Add validation for hand decomposition#190Nihisil merged 10 commits intoMahjongRepository:masterfrom
Nihisil merged 10 commits intoMahjongRepository:masterfrom
Conversation
Collaborator
Author
|
Sorry, there was a lack of validation when melds is present. I added a test case first. |
Collaborator
Author
|
Validation added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#171
Added validation for hand decomposition.
This ensures that if the hand decomposition is successful, the hand is Agari, and if it fails, the hand is not Agari (except for Kokushi Musou).
Also added comments explaining how the algorithm automatically rejects invalid hands.