Fix #12: pass ./maho relative to cwd instead of the host absolute path

[fballiano]

Fixes #12.

The bug

activate() built the LSP and MCP commands with path.join(workspaceFolder.uri.fsPath, 'maho'), an absolute host path. When maho.phpCommand runs PHP inside a container, that path does not exist in the container's filesystem namespace, so the server failed with Could not open input file: /abs/host/path/maho.

package.json and issue #1 both documented the setting as prepended to ./maho dev:lsp:start, so the implementation had drifted from the documented contract.

The fix

Pass ./maho in the argv. cwd was already set to the workspace root for both the LanguageClient (options.cwd) and the MCP server definition (definition.cwd), so native and custom-PHP-path setups are unchanged. The absolute path is still computed for the fs.existsSync activation check.

maho.phpCommand	Before	After
php	php /abs/path/maho … ✓	php ./maho … ✓
/usr/local/bin/php8.3	✓	✓
docker exec -w /app php	✗	✓
docker exec mycontainer php	✗ (unless host path == container path)	✗ (see docs below)

Docs

The Docker examples in README.md and package.json used docker exec mycontainer php, with no -w. That case cannot work with a relative script path, and only worked before by accident when the host and container paths happened to match. Both now show -w and explain that ./maho resolves against the container's working directory.

AGENTS.md did not mention MCP registration at all, and now records the relative-path invariant so it does not regress.

CI

New .github/workflows/ci.yml runs npm ci → typecheck → compile → vsce package on pushes to main and on all PRs. The packaging step matters because the release workflow only runs after the tag exists, and immutable releases mean a burned tag cannot be reused. release.yml now typechecks before compiling.

To be clear about the limits: none of this CI would have caught this bug. npm run compile is a bare esbuild bundle that strips types without checking them, and even tsc sees two valid strings. Catching this needs a test asserting the constructed argv, which means introducing a test runner and a vscode module mock. Not done here.

Verification

npm run typecheck and npm run compile pass; the bundle emits var MAHO_SCRIPT = "./maho". Not tested against a live Docker setup.

Note

Developed with the help of AI.
As part of our commitment to GenAI transparency, we flag pull requests produced with AI assistance alongside human work. As with every change in Maho, a maintainer reviews and validates it before merge, we never merge purely AI-generated changes. See the GenAI transparency section for details.

[empiricompany]

For custom Docker configurations, the -i option must be added to the docker exec command. This keeps the process stdin open and prevents the LSP server from being closed immediately after startup.

The documentation should be updated to highlight this requirement in the examples for maho.phpCommand and Docker-based configurations.

(e.g. docker exec -i -w /var/www/html mycontainer php

[fballiano]

@empiricompany documentation updated!