database/link: Load the domain databases automatically#94
Open
Inhishonor wants to merge 9 commits intostablefrom
Open
database/link: Load the domain databases automatically#94Inhishonor wants to merge 9 commits intostablefrom
Inhishonor wants to merge 9 commits intostablefrom
Conversation
On boot, this code attempted to read shared preferences before it existed, leading to a NPE.
In line with Kotlin syntax.
Move them to strings.xml as they are user-facing and should be translated.
Moved to Coroutines, deduplicated code, and updated various bits.
Inhishonor
force-pushed
the
domain-database-loading
branch
from
e999109 to
07fd722
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds support to automatically load the domain databases whenever they are needed. It adds a separate signature database for only domains to work from.
Finishes out and Closes: #87