Show a falsified grounding where an agent actually reads it - #14
Merged
Conversation
Stale grounding rendered only in `full_record` — `get`. An agent recalls,
reads the ranked lines, and acts on the top hits; it does not then call
`get` on each one. So the signal shipped last week reached whoever ran
`mimir doctor` and nobody else, which is close to the failure mode the
flag was supposed to avoid.
The compact line now carries `stale-link` in the bracket, the same
one-word treatment `unsure` gets, on affected hits only:
m:QJ18BM [gotcha pr:src 08-11 stale-link] retry_with_backoff doubles …
m:A1YRN7 [note pr:src 08-11] unrelated note about the retry budget
Resolved once per page via `grounding::stale_ids`, not per hit: recall is
a hot path, the marker is usually absent, and a query per result to print
nothing is a bad trade. A test asserts the batch lookup and the per-node
`grounding()` can never disagree — a split-brain between what recall shows
and what `get` shows is exactly the `supersedes` edge-vs-column bug in a
new costume.
Still not a ranking signal. Measured on a real 714-memory store first,
read-only, to check that was still the right call:
grounded 10 1.4%
stale 1 0.1%
ungrounded 703 98.5%
Scoring would move eleven records. The store holds 91k symbols, 16.7k doc
chunks and 12.3k files, and 247 memories (34.6%) do have edges — but to
other memories and to tags, not to artifacts. So the ceiling on grounding
is not the ranking policy, it is that `mimir link --scan` is a manual
per-project command nobody runs. Same shape as anchors at 0 of 612.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stale grounding rendered only in
full_record— i.e.get. An agentrecalls, reads the ranked lines, and acts on the top hits; it does not then
call
geton each one. So the signal shipped last week reached whoever ranmimir doctorand essentially nobody else.The compact line now carries
stale-linkin the bracket, the same one-wordtreatment
unsuregets, on affected hits only:Resolved once per page via
grounding::stale_ids, not per hit — recall is ahot path, the marker is usually absent, and a query per result to print
nothing is a bad trade. A test asserts the batch lookup and per-node
grounding()can never disagree; a split-brain between what recall showsand what
getshows would be thesupersedesedge-vs-column bug in a newcostume.
Still not a ranking signal, and now there's a number behind that
Measured read-only on a real 714-memory store before deciding:
Scoring grounding would move eleven records. The store holds 91k symbols,
16.7k doc chunks and 12.3k files, and 247 memories (34.6%) do carry
edges — but to other memories and tags, not to artifacts.
So the ceiling on grounding isn't the ranking policy, it's that
mimir link --scanis a manual per-project command nobody runs. Same shapeas anchors sitting at 0 of 612 adoption. Discoverability work tracked
separately.
Review notes
agent_line_for_querygains astale_groundingflag;agent_linedelegates with
false, so the single-node echo paths (remember, mark,list) don't pay for a lookup that would almost always return
false.-D warnings, 385 tests, plus before/after verified againstthe real binary.