Add Base64 compat helper - #9
Open
wemotion-team wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds backward compatibility for Base64 decoding to support Android 7 (API < 26) devices by introducing a compatibility helper method that switches between java.util.Base64 (API 26+) and android.util.Base64 (older versions).
Key Changes:
- Added
decodeBase64Compathelper method that handles API level branching for Base64 decoding - Updated
imageandrawmethods to use the compatibility helper instead ofjava.util.Base64 - Removed
@RequiresApiannotations andjava.util.Base64import that were tying the code to API 26+
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…rThermalPrinterPlugin.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android Base64 Compatibility
decodeBase64CompatinsideCapacitorThermalPrinterPluginthat prefersjava.util.Base64on API 26+ and falls back toandroid.util.Base64below that, so Android 7 devices can still decode print payloads.imageandrawhandlers to use the helper, removing API-level annotations/imports tied tojava.util.Base64.