Fix Reddit Gallery Gif Downloads - #417
Merged
Merged
Conversation
Reddit gallery parsing was missing gif files due to the way the urls were extracted from the albums and the way the extensions were found. This fixes both issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files inside of gallery posts were being silently skipped when they were .gif or .mp4 files. This was caused by the extractor logic not accounting for the differences in the returned data structures between regular image files and 'animated' files.
This fix updates the
RedditUploadsExtractorto account for this different format and extract .gif and .mp4 files correctly.Closes #416