feat(appearance): add bar padding - #971
Merged
Merged
Conversation
The bar had a hardcoded `[xxs, xxs]` padding applied only to the transparent surface, so the inset was neither configurable nor available to solid bars. #915 removes that padding in favour of `margin`, which leaves a bar with no configuration sitting flush against the screen edge. `margin` is not a substitute for it. It moves the layer surface itself, so the gap belongs to the compositor: a solid bar stops spanning the full width, and the bar no longer receives clicks or scroll events at the screen edge, which is the easiest place to aim at. Padding keeps the surface where it is and insets only the content, so the solid background still reaches both edges and the whole bar stays reachable. Add `[appearance.bar].padding` with the same CSS shorthand and value types as `margin`, defaulting to `xxs`. `HEIGHT` now describes the content, and the surface is the content plus the vertical padding, so the default reproduces the current transparent height exactly. Padding is drawn inside the surface and therefore scales with `scale_factor`, unlike `margin`, which the compositor applies in screen pixels. Solid bars grow by 8px at the default, which is the intended change: the content is no longer flush against the screen edge.
MalpenZibo
force-pushed
the
feat/bar-padding
branch
from
September 17, 2026 21:20
483a1b2 to
e4aa7de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.