Skip to content

feat: pydantic as fields#2

Open
kk-cycls wants to merge 3 commits into
Mamdouh66:mainfrom
kk-cycls:feat/paydantic-as-fields
Open

feat: pydantic as fields#2
kk-cycls wants to merge 3 commits into
Mamdouh66:mainfrom
kk-cycls:feat/paydantic-as-fields

Conversation

@kk-cycls

Copy link
Copy Markdown

Hala mamdouh, loved your work and I would love to add to it

  • adding support for pydantic as an extractor fields.
  • adding support for pyright
  • some enhancement of the type annotation

@kk-cycls

Copy link
Copy Markdown
Author

using pydantic is great to define the expected outcome because we can allow for more complex data types.
one can use the fast offering from pydantic to customise and utilise this object as an extra prompting instrument

@Mamdouh66

Copy link
Copy Markdown
Owner

Hello Khalid, thanks for you kind words and support.

sorry it took a long time to respond, a few notes.

  • The base extractor main point is to have a base rich response, when i ran your version it tend to be more simple without more robust details. If you can look into it to ensure it would be more rich I would appreciate that specially in the data_model where it has content
  • make sure please to use the pre-commit to ensure black formatting
  • for the FIXME the async is for the commented playwright version the function was async but I stopped using playwright for now because it takes a longer time and has more dependencies

other than thatI love your way of typing and I am thankful for your help, please tell if you can do the notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants