Repository navigation
Audible: do not file another book by the same author from a tagged ASIN - #39
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
A leftover AUDIBLE_ASIN of another title by the same author passed the author-only gate (requireTitle was false on the legacy attempt) and beat matchrate 60. Require a title match for a tagged ASIN when the id3 or parsed title is usable, and do not retry that ASIN against a junk id3 title after the parsed title already rejected it. Co-authored-by: Mancolt <Mancolt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
A file with a usable id3 title and an
AUDIBLE_ASINtag pointing at a different book by the same author was filed under that other title. Typical trigger: leftover tag from another encode in the same author's series (The Girl on the Train tagged as Into the Water, token_sort 77, abovematchrate60). Same hole with a ripperAudioTrack 01title after the parsed folder name had already rejected the ASIN.#23's fallback already handled a dead ASIN or a different author. Same-author wrong tags never reached it because the author-only gate accepted the per-ASIN product.
Root cause
Audible's per-ASIN lookup ignores title.
_audibleAttemptsleftrequireTitle=Falseon the legacy attempt, so_rankAudibleaccepted on author alone. After a parsed title-gated miss, legacy retried the same ASIN against the junk id3 title and the author-only gate won again.Fix
(Unabridged)) are unchanged.Validation
TaggedAsinFallbackTest: same-author leftover ASIN falls back;(Unabridged)still accepts a live tag; junk id3 title does not let the leftover ASIN beat the parsed folder title.