Audit fixes: tags, ownership controls, naming, contact vars, LICENSE - #10
Merged
Conversation
…ct vars, LICENSE, gitignore - Add tags to 6 S3 buckets (cloudtrail, vpc-flow-logs, alb-access-logs, data-classification, config-logs, control-tower) - Add S3 ownership controls to 4 buckets (vpc-flow-logs, control-tower, data-classification, mtls-trust-store) - Rename IAM policies to use npci- prefix (force-mfa, quarterly-access-review, access-analyzer-integration) - Extract hardcoded contact info to variables (security_email, security_phone) - Remove hardcoded account ID from setup-mtls-ca.sh (require env var) - Add Apache-2.0 LICENSE file - Add soc.txt to .gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Final audit cleanup fixes based on code coverage and plagiarism/duplication audit:
Tags & Ownership Controls
aws_s3_bucket_ownership_controlsto 4 S3 buckets (vpc-flow-logs, control-tower, data-classification, mtls-trust-store)Naming Consistency
npci-prefix:ForceMFAPolicy→npci-force-mfa-policy,QuarterlyAccessReviewPolicy→npci-quarterly-access-review-policy,AccessAnalyzerIntegrationPolicy→npci-access-analyzer-integration-policyHardcoded Values → Variables
security-team@npci.org.infrom cloudwatch-alarms tovar.security_emailsecurity@npci.org.inand+91XXXXXXXXXXfrom incident-response tovar.security_emailandvar.security_phonesetup-mtls-ca.sh— now requiresAWS_ACCOUNT_IDenv varSecurity & Compliance
soc.txtto .gitignore (contains sensitive assessment data)What was NOT changed (and why)
arn:aws:iam::aws:policy/...— these are correct AWS-managed policy ARNs with empty account IDs3-secure-bucketmodule)Testing
terraform validatepasses