fix: close sanitizer and registry merge critical paths#10
Draft
cursor[bot] wants to merge 4 commits into
Draft
Conversation
Co-authored-by: Andre Schu <Art.Int.Interface@gmail.com>
Co-authored-by: Andre Schu <Art.Int.Interface@gmail.com>
Co-authored-by: Andre Schu <Art.Int.Interface@gmail.com>
Co-authored-by: Andre Schu <Art.Int.Interface@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
source_refmetadata accepted arbitrary fields and non-stringlang, allowing sensitive metadata to persist in snapshots and malformed local SSOT data to crash registry projection.Root cause
source_refwas open-ended in both runtime validation and schema despite onlylangbeing used for multilingual projection.apply_merge()wrote merge outputs directly rather than staging both files and validating merged local state before persistence.Fix
encoding_depthfinding and classify exhausted canonicalization as injection.source_refvalidation/schema to optional boundedlangmetadata.Validation
PYTHONPATH=src python3 -m pytest -q tests/test_sanitize_encoding_evasion.py tests/test_registry_contribute_r3.py tests/test_pattern_record_r1.py tests/test_registry_fetch_r4.py tests/test_registry_ssot.py tests/test_security_regressions.py-> 128 passed.git diff --check-> passed.PYTHONPATH=src python3 -m pytest -q-> 287 passed / 3 skipped / 3 failed; failures are the pre-existing vendored contract hash mismatches intests/test_contract_document_hash.pynoted in automation memory.