Fix registry contribution and SSOT safety gaps#12
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Andre Schu <Art.Int.Interface@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
patterns_jsoncontribution could carry raw prompt text insource_refmetadata and publish it in the registry snapshot whenapprove=trueand consent/host allowlist were configured.reversaltier instead ofinjection, soscp_validate_outputwould still mark them safe.Root cause
source_refkeys/values.Fix
source_ref.langto language-tag metadata.Validation
PYTHONPATH=src python3 -m pytest -q tests/test_registry_contribute_r3.py::test_structured_patterns_rejects_unknown_detector_field tests/test_registry_contribute_r3.py::test_structured_patterns_rejects_unabstracted_source_ref_metadata tests/test_registry_contribute_r3.py::test_structured_patterns_rejects_unabstracted_source_ref_lang_value tests/test_sanitize_encoding_evasion.py::TestComposition::test_deep_url_encoded_injection_classified tests/test_registry_ssot.py::test_load_ssot_returns_empty_for_corrupt_json tests/test_registry_ssot.py::test_apply_merge_does_not_commit_ssot_when_projection_write_fails-> 6 passedPYTHONPATH=src python3 -m pytest -q tests/test_registry_contribute_r3.py tests/test_sanitize_encoding_evasion.py tests/test_registry_ssot.py tests/test_registry_load_order_r5.py tests/test_registry_fetch_r4.py tests/test_appsec_host_allowlists.py-> 116 passedPYTHONPATH=src python3 -m pytest -qwith.[dev,antigen]installed -> 286 passed, 3 skipped, 3 known baseline contract hash failures intests/test_contract_document_hash.py