Add Readiness and Liveness Probes to All Deployments#49
Merged
Manoj-14 merged 17 commits intoManoj-14:stagefrom Jan 12, 2026
Merged
Conversation
- workflows are added - minikube tunnling are added - metric-server is added - some devops optimisation
- Auto comment for PR's
- k8s files are combined for each service - auto comment workflow updated
Hi @reshma2004 Thanks for creating a PR for your Issue!
|
Manoj-14
requested changes
Jan 11, 2026
Owner
Manoj-14
left a comment
There was a problem hiding this comment.
Hey @reshma2004. Please review the changes for login-service.yaml file. Other then that every thig loogs good for me.
Author
|
I changed the version back to v1.2.0 |
c05db60 to
637ab5a
Compare
637ab5a to
f0e9299
Compare
Author
|
I had some difficulty pushing files. Yes, I changed the version back to v1.2.0. |
Manoj-14
approved these changes
Jan 12, 2026
Owner
Manoj-14
left a comment
There was a problem hiding this comment.
Thanks @reshma2004 for resolving the issue, will merge it to stage then will merge to master.
Author
|
Hi Manoj,
Thanks for merging the PR. ! I'm glad I could contribute.Looking
forward to contributing.
Thanks
Reshma
…On Sun, Jan 11, 2026 at 7:05 AM Manoj M ***@***.***> wrote:
Closed #49 <#49>.
—
Reply to this email directly, view it on GitHub
<#49 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADGWF7RSKJEOMYKHB7TXKFD4GI37BAVCNFSM6AAAAACRJK7JQWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRHE3DSOJSHEZDMNI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄
Pull Request Template📌 Description
Please provide a clear and concise description of the changes in this PR.
What does this PR do?
Why is this change needed?
🔗 Related Issue
Link the issue this PR addresses (if applicable):
Fixes #25
🛠️ Type of Change
Please mark the relevant option:
🧪 How Was This Tested?
Describe how you verified your changes:
📸 Screenshots (if applicable)
Add screenshots or logs if this change affects UI or behavior.
✅ Checklist
Please confirm the following:
📝 Additional Notes
Anything else the maintainers should know?
login-service.yaml had missing labels and different container image(v1.2.0). Rest other service files had container image v1.1.0 So I modified the container image and added missing labels. in login-service.yaml. However container images does not match with readme.md and setup.md. I also added rolling update.