Feature/strategy pattern fixes#9
Open
VisheshRampersad wants to merge 3 commits into
Open
Conversation
…it file, schedule class, the three scheduling methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My previous code did not reflect the UML class diagram and upon review by other members significant changes were needed. Primarily, it was missing the schedule generator, I did not refactor the existing schedule class, there was admin check in the controller. As such, I updated all the files to match the diagram, removed admin check, refactored the class, renamed functions and classes, deleted old files.