Fix: Custom icon does not appear on Mapbox - #42
Merged
Conversation
* Consolidated BounceAnimation and refactored the animation callers.
* Consolidated BounceAnimation and refactored the animation callers.
# Conflicts: # mapconductor-core/src/main/java/com/mapconductor/core/controller/MapViewController.kt # mapconductor-core/src/main/java/com/mapconductor/core/marker/MarkerOverlayManagerImpl.kt # mapconductor-core/src/main/java/com/mapconductor/settings/Settings.kt # mapconductor-for-arcgis/src/main/java/com/mapconductor/arcgis/ArcGISMapViewController.kt # mapconductor-for-googlemaps/src/main/java/com/mapconductor/googlemaps/GoogleMapViewController.kt # mapconductor-for-here/src/main/java/com/mapconductor/here/HereMapViewController.kt # mapconductor-for-mapbox/src/main/java/com/mapconductor/mapbox/MapboxMapViewController.kt
# Conflicts: # mapconductor-core/src/main/java/com/mapconductor/core/controller/MapViewController.kt # mapconductor-core/src/main/java/com/mapconductor/core/marker/MarkerOverlayManagerImpl.kt # mapconductor-core/src/main/java/com/mapconductor/settings/Settings.kt # mapconductor-for-arcgis/src/main/java/com/mapconductor/arcgis/ArcGISMapViewController.kt # mapconductor-for-googlemaps/src/main/java/com/mapconductor/googlemaps/GoogleMapViewController.kt # mapconductor-for-here/src/main/java/com/mapconductor/here/HereMapViewController.kt # mapconductor-for-mapbox/src/main/java/com/mapconductor/mapbox/MapboxMapViewController.kt
…d-sdk into marker_animation
wf9a5m75
added a commit
that referenced
this pull request
Jul 6, 2025
* Spin out icons code into the mapconductor-icons module * Spin out icons code into the mapconductor-icons module * Add onAnimation parameter for MarkerOvervalyManaer. * Add onAnimation parameter for MarkerOvervalyManaer. * Remove unnecessary library * Remove unnecessary library * Implement basic structure * Implement basic structure * Implement initial marker drop animation * Implement initial marker drop animation * Added drop animation * Added drop animation * Implementing marker drop animation * Implementing marker drop animation * Improve the marker rendering performance by observing marker state change using flow. The flow debounce reduces unnecessary the number of execution of the updateMarker. * Improve the marker rendering performance by observing marker state change using flow. The flow debounce reduces unnecessary the number of execution of the updateMarker. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Fix: marker.animation does not work * Fix: marker.animation does not work * Implement onMarkerAnimateStart and onMarkerAnimateEnd callbacks * Implement onMarkerAnimateStart and onMarkerAnimateEnd callbacks * No longer take care of coroutineScope by MarkerOverlayManagerImpl * No longer take care of coroutineScope by MarkerOverlayManagerImpl * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Add Bounce Animation@google Maps * Add Bounce Animation@google Maps * ArcGIS animation.(debug now) * ArcGIS animation.(debug now) * wip: debugging with claude.ai * wip: debugging with claude.ai * ArcGIS:Apply debug results Here:Create animation(Drop/Bounce) * ArcGIS:Apply debug results Here:Create animation(Drop/Bounce) * Unify variable naming and processing sequence across codebases(Google Maps, ArcGIS, HERE). Scope: Drop and Bounce animations. * Unify variable naming and processing sequence across codebases(Google Maps, ArcGIS, HERE). Scope: Drop and Bounce animations. * "Extracted common logic for Drop Animation across Google Maps, ArcGIS, and HERE into a separate function." * "Extracted common logic for Drop Animation across Google Maps, ArcGIS, and HERE into a separate function." * Update .gitignore (#34) * Update .gitignore (#34) * Create MarkerEntity (#35) * Create MarkerEntity (#35) * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Unified Drop Animation for ArcGIS and Google Maps. * Unified Drop Animation for ArcGIS and Google Maps. * wip: polyline * wip: polyline * pause working on polyline. Just clear all overlays for temporally * pause working on polyline. Just clear all overlays for temporally * Generate marker Id based on the constructor parameters if omitted. * Generate marker Id based on the constructor parameters if omitted. * Comment out debug code * Comment out debug code * Implement marker dragging functionality for Mapbox * Implement marker dragging functionality for Mapbox * KtLinter auto fixed * KtLinter auto fixed * * Integrated the shared Drop Animation into HERE Map. * Consolidated BounceAnimation and refactored the animation callers. * * Integrated the shared Drop Animation into HERE Map. * Consolidated BounceAnimation and refactored the animation callers. * create drawDragLayer private method * create drawDragLayer private method * Fix: Bounce animation does not work * Fix: Bounce animation does not work * Fix: Changing the marker.icon value does not work. * Fix: Changing the marker.icon value does not work. * fix: the flyTo button on the demo app does not work * probably fix: icon anchor is incorrect on Mapbox * Fix: custom icon does not appear on mapbox * Resolve linter errors --------- Co-authored-by: KouTsukigase <kou.tsukigase@gmail.com>
KouTsukigase
added a commit
that referenced
this pull request
Jul 25, 2025
* Spin out icons code into the mapconductor-icons module * Spin out icons code into the mapconductor-icons module * Add onAnimation parameter for MarkerOvervalyManaer. * Add onAnimation parameter for MarkerOvervalyManaer. * Remove unnecessary library * Remove unnecessary library * Implement basic structure * Implement basic structure * Implement initial marker drop animation * Implement initial marker drop animation * Added drop animation * Added drop animation * Implementing marker drop animation * Implementing marker drop animation * Improve the marker rendering performance by observing marker state change using flow. The flow debounce reduces unnecessary the number of execution of the updateMarker. * Improve the marker rendering performance by observing marker state change using flow. The flow debounce reduces unnecessary the number of execution of the updateMarker. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Fix: marker.animation does not work * Fix: marker.animation does not work * Implement onMarkerAnimateStart and onMarkerAnimateEnd callbacks * Implement onMarkerAnimateStart and onMarkerAnimateEnd callbacks * No longer take care of coroutineScope by MarkerOverlayManagerImpl * No longer take care of coroutineScope by MarkerOverlayManagerImpl * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Add Bounce Animation@google Maps * Add Bounce Animation@google Maps * ArcGIS animation.(debug now) * ArcGIS animation.(debug now) * wip: debugging with claude.ai * wip: debugging with claude.ai * ArcGIS:Apply debug results Here:Create animation(Drop/Bounce) * ArcGIS:Apply debug results Here:Create animation(Drop/Bounce) * Unify variable naming and processing sequence across codebases(Google Maps, ArcGIS, HERE). Scope: Drop and Bounce animations. * Unify variable naming and processing sequence across codebases(Google Maps, ArcGIS, HERE). Scope: Drop and Bounce animations. * "Extracted common logic for Drop Animation across Google Maps, ArcGIS, and HERE into a separate function." * "Extracted common logic for Drop Animation across Google Maps, ArcGIS, and HERE into a separate function." * Update .gitignore (#34) * Update .gitignore (#34) * Create MarkerEntity (#35) * Create MarkerEntity (#35) * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Unified Drop Animation for ArcGIS and Google Maps. * Unified Drop Animation for ArcGIS and Google Maps. * wip: polyline * wip: polyline * pause working on polyline. Just clear all overlays for temporally * pause working on polyline. Just clear all overlays for temporally * Generate marker Id based on the constructor parameters if omitted. * Generate marker Id based on the constructor parameters if omitted. * Comment out debug code * Comment out debug code * Implement marker dragging functionality for Mapbox * Implement marker dragging functionality for Mapbox * KtLinter auto fixed * KtLinter auto fixed * * Integrated the shared Drop Animation into HERE Map. * Consolidated BounceAnimation and refactored the animation callers. * * Integrated the shared Drop Animation into HERE Map. * Consolidated BounceAnimation and refactored the animation callers. * create drawDragLayer private method * create drawDragLayer private method * Fix: Bounce animation does not work * Fix: Bounce animation does not work * Fix: Changing the marker.icon value does not work. * Fix: Changing the marker.icon value does not work. * fix: the flyTo button on the demo app does not work * probably fix: icon anchor is incorrect on Mapbox * Fix: custom icon does not appear on mapbox * Resolve linter errors --------- Co-authored-by: KouTsukigase <kou.tsukigase@gmail.com>
wf9a5m75
added a commit
that referenced
this pull request
Aug 2, 2025
* Spin out icons code into the mapconductor-icons module * Spin out icons code into the mapconductor-icons module * Add onAnimation parameter for MarkerOvervalyManaer. * Add onAnimation parameter for MarkerOvervalyManaer. * Remove unnecessary library * Remove unnecessary library * Implement basic structure * Implement basic structure * Implement initial marker drop animation * Implement initial marker drop animation * Added drop animation * Added drop animation * Implementing marker drop animation * Implementing marker drop animation * Improve the marker rendering performance by observing marker state change using flow. The flow debounce reduces unnecessary the number of execution of the updateMarker. * Improve the marker rendering performance by observing marker state change using flow. The flow debounce reduces unnecessary the number of execution of the updateMarker. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Define the marker drop animate duration in the default constants. * Fix: marker.animation does not work * Fix: marker.animation does not work * Implement onMarkerAnimateStart and onMarkerAnimateEnd callbacks * Implement onMarkerAnimateStart and onMarkerAnimateEnd callbacks * No longer take care of coroutineScope by MarkerOverlayManagerImpl * No longer take care of coroutineScope by MarkerOverlayManagerImpl * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Add Bounce Animation@google Maps * Add Bounce Animation@google Maps * ArcGIS animation.(debug now) * ArcGIS animation.(debug now) * wip: debugging with claude.ai * wip: debugging with claude.ai * ArcGIS:Apply debug results Here:Create animation(Drop/Bounce) * ArcGIS:Apply debug results Here:Create animation(Drop/Bounce) * Unify variable naming and processing sequence across codebases(Google Maps, ArcGIS, HERE). Scope: Drop and Bounce animations. * Unify variable naming and processing sequence across codebases(Google Maps, ArcGIS, HERE). Scope: Drop and Bounce animations. * "Extracted common logic for Drop Animation across Google Maps, ArcGIS, and HERE into a separate function." * "Extracted common logic for Drop Animation across Google Maps, ArcGIS, and HERE into a separate function." * Update .gitignore (#34) * Update .gitignore (#34) * Create MarkerEntity (#35) * Create MarkerEntity (#35) * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Revert "Update .editorconfig (#32)" This reverts commit c7805d4. * Unified Drop Animation for ArcGIS and Google Maps. * Unified Drop Animation for ArcGIS and Google Maps. * wip: polyline * wip: polyline * pause working on polyline. Just clear all overlays for temporally * pause working on polyline. Just clear all overlays for temporally * Generate marker Id based on the constructor parameters if omitted. * Generate marker Id based on the constructor parameters if omitted. * Comment out debug code * Comment out debug code * Implement marker dragging functionality for Mapbox * Implement marker dragging functionality for Mapbox * KtLinter auto fixed * KtLinter auto fixed * * Integrated the shared Drop Animation into HERE Map. * Consolidated BounceAnimation and refactored the animation callers. * * Integrated the shared Drop Animation into HERE Map. * Consolidated BounceAnimation and refactored the animation callers. * create drawDragLayer private method * create drawDragLayer private method * Fix: Bounce animation does not work * Fix: Bounce animation does not work * Fix: Changing the marker.icon value does not work. * Fix: Changing the marker.icon value does not work. * fix: the flyTo button on the demo app does not work * probably fix: icon anchor is incorrect on Mapbox * Fix: custom icon does not appear on mapbox * Resolve linter errors --------- Co-authored-by: KouTsukigase <kou.tsukigase@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug that Marker does not draw custom icon but default icon is drew.
This bug was introduced by #41.