Conversation
- Use TextureView instead of SurfaceView for Mapbox SDK
* Introduce KtLint * Fix: KtLint errors * fix: Android lint errors * add reviewdog check * Run KtLint and Android lint for every commits * Detect the code change by modules * continue steps if no cache * fix: duplicate steps are defined in the code_check.yml * merge code_check.yml and reviewdog_pr.yml into ci.yml * Add necessary files * Fix: the ci workflow can not find the projects.properties file * fix: KtLint does not work * fix: KtLint and Android Lint errors * fix: no value for <HERE_ACCESS_KEY_SECRET> is provided * Separate lint and review actions
* Introduce KtLint * Fix: KtLint errors * fix: Android lint errors * add reviewdog check * Run KtLint and Android lint for every commits * Detect the code change by modules * continue steps if no cache * fix: duplicate steps are defined in the code_check.yml * merge code_check.yml and reviewdog_pr.yml into ci.yml * Add necessary files * Fix: the ci workflow can not find the projects.properties file * fix: KtLint does not work * fix: KtLint and Android Lint errors * fix: no value for <HERE_ACCESS_KEY_SECRET> is provided * Separate lint and review actions
* wip * Fix: InfoWindow positioning is incorrect (confirmed: Google Maps, Mapbox, and Here. Not confirmed yet: ArcGIS) * Info bubbles follow the dragged markers. * update: .gitignore file * wip: Implementing the marker drag gesture for Here SDK * fix: linter errors * fix: duplicated markers are added * fix: KtLint errors * update README.md * The mapProvider of MapViewBase is no longer necessary * Implement toasting logic in AppViewModel * Create Settings class for defining default values * rename MapView.kt to MapViewContainer.kt * Fix: Cannot follow the map camera position for ArcGIS MapView * Fix: InfoBubble does not follow the clicked marker on ArcGIS MapView * Fix: onMapClick does not be involved * Optimize code structure * Fix: InfoBubble does not follow on ArcGIS Mapview when device is rotated * Fix: linter errors * Launch Google Maps app when taps on the "Get Directions" button in InfoBubble
* wip * Fix: InfoWindow positioning is incorrect (confirmed: Google Maps, Mapbox, and Here. Not confirmed yet: ArcGIS) * Info bubbles follow the dragged markers. * update: .gitignore file * wip: Implementing the marker drag gesture for Here SDK * fix: linter errors * fix: duplicated markers are added * fix: KtLint errors * update README.md * The mapProvider of MapViewBase is no longer necessary * Implement toasting logic in AppViewModel * Create Settings class for defining default values * rename MapView.kt to MapViewContainer.kt * Fix: Cannot follow the map camera position for ArcGIS MapView * Fix: InfoBubble does not follow the clicked marker on ArcGIS MapView * Fix: onMapClick does not be involved * Optimize code structure * Fix: InfoBubble does not follow on ArcGIS Mapview when device is rotated * Fix: linter errors * Launch Google Maps app when taps on the "Get Directions" button in InfoBubble
…through the parent MapView (#17)
…through the parent MapView (#17)
* MarkerEntry is no longer necessary. Developer receives marker events through the parent MapView * implement marker_drag_start, marker_drag, marker_drag_end for GoogleMaps, Mapbox, and Here * Fix: Dragging marker on Here stops while it's dragging * Implemente marker drag feature for ArcGIS
* MarkerEntry is no longer necessary. Developer receives marker events through the parent MapView * implement marker_drag_start, marker_drag, marker_drag_end for GoogleMaps, Mapbox, and Here * Fix: Dragging marker on Here stops while it's dragging * Implemente marker drag feature for ArcGIS
* create BaseMapViewSaver and each mapview saver inherits it
* create BaseMapViewSaver and each mapview saver inherits it
* Optimize Linter Action triggers * Cancel the previous action if a new commit is added on the same branch
…(changed the implementation method).
* No longer the mapbox_access_key.xml file is used. Set the token in secrets.properties file * fix: KtLint Errors --------- Co-authored-by: KouTsukigase <kou.tsukigase@gmail.com>
Co-authored-by: KouTsukigase <kou.tsukigase@gmail.com>
…ircles as well." This reverts commit 6be0db4.
…the Google Maps API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.