[wip] feat: upgrade libp2p, apply breaking changes#2
Open
ratik21 wants to merge 5 commits intoMarcoPolo:masterfrom
Open
[wip] feat: upgrade libp2p, apply breaking changes#2ratik21 wants to merge 5 commits intoMarcoPolo:masterfrom
ratik21 wants to merge 5 commits intoMarcoPolo:masterfrom
Conversation
Author
|
@MarcoPolo could you please review? |
MarcoPolo
requested changes
Sep 9, 2022
Owner
MarcoPolo
left a comment
MarcoPolo
left a comment
There was a problem hiding this comment.
Could you add a test that fails with your changes but worked in the old version?
| "y-protocols": "^1.0.x", | ||
| "peer-id": ">=0.16.0" | ||
| "@libp2p/peer-id": "^1.1.15", | ||
| "y-protocols": "^1.0.x" |
Owner
There was a problem hiding this comment.
You need to update the peer dependency below
| // @ts-ignore | ||
| import * as awarenessProtocol from 'y-protocols/dist/awareness.cjs' | ||
| import Libp2p from 'libp2p' | ||
| import {Libp2p as ILibp2p} from 'libp2p' |
Author
There was a problem hiding this comment.
I was using libp2p class type as Libp2p (so prefixed an I). It was also giving a type error (related to namespace)
| this.node.pubsub.unsubscribe(awarenessProtocolTopic(this.topic)) | ||
| this.node.pubsub.removeAllListeners(awarenessProtocolTopic(this.topic)) | ||
|
|
||
| this.node.pubsub.removeEventListener('message'); |
Owner
There was a problem hiding this comment.
Did this change in the new version of js libp2p?
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are not working (trying to fix an import issue).
The code seems fine but i am still having issues (with remote yjs public docs syncing) when i am using it. Could you please review the code @MarcoPolo ? Thanks