Don't unintentionally close stdin on non-Windows.#74
Open
MMOSimca wants to merge 1 commit into
Open
Conversation
The SafeHandle that is used to implement IDisposable was copied from the .NET docs and isn't needed. It leads to unintentionally closing stdin (file descriptor zero) on non-Windows platforms, which causes to hard to diagnose issues in other code.
Author
|
Hi @Marilyth! I recently encountered a difficult-to-nail-down issue relating to using sockets on Linux and found that this specific line of code was my problem. Trying to track down any other code I can find with the same problem to let people know what's wrong. I don't know if this was causing you any issues (it would have been whenever this BaseTracker class was disposed), but even if it wasn't, there should be no negative effects from this change. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SafeHandle that is used to implement IDisposable was copied from the .NET docs and isn't needed. It leads to unintentionally closing stdin (file descriptor zero) on non-Windows platforms, which causes to hard to diagnose issues in other code.
See dotnet/runtime#64305.