Don't init .auth object until .onLoad#195
Merged
MarkEdmondson1234 merged 1 commit intoMarkEdmondson1234:masterfrom Nov 12, 2020
Merged
Don't init .auth object until .onLoad#195MarkEdmondson1234 merged 1 commit intoMarkEdmondson1234:masterfrom
MarkEdmondson1234 merged 1 commit intoMarkEdmondson1234:masterfrom
Conversation
Creating the .auth object directly at the top-level means the code from gargle is snapshotted at build time.
Contributor
Author
|
@jennybc I hope I didn't jump the gun with these PRs? Does this look good to you? |
|
With the caveat that my head is elsewhere, yes looks good to me. |
Owner
|
Thanks, I saw the conversation on gargle and was wondering how it would affect here. I'll test this with a few downstream packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating the .auth object directly at the top-level means the code
from gargle is snapshotted at build time.
This is needed for r-lib/gargle#157, but is a good change even without that PR.