-
Notifications
You must be signed in to change notification settings - Fork 1
feat: improve thinking detection and add usage overlay #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ALTER TABLE sessions ADD COLUMN claude_session_id TEXT; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -19,6 +19,7 @@ import ( | |||||||||||||||||||||||||
| "github.com/valentindosimont/ccmanager/internal/store" | ||||||||||||||||||||||||||
| "github.com/valentindosimont/ccmanager/internal/tmux" | ||||||||||||||||||||||||||
| "github.com/valentindosimont/ccmanager/internal/tui/messages" | ||||||||||||||||||||||||||
| "github.com/valentindosimont/ccmanager/internal/usage" | ||||||||||||||||||||||||||
| "github.com/valentindosimont/ccmanager/internal/workspace" | ||||||||||||||||||||||||||
| ) | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
@@ -61,6 +62,10 @@ type Model struct { | |||||||||||||||||||||||||
| // Activity overlay | ||||||||||||||||||||||||||
| showActivity bool | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| // Usage overlay | ||||||||||||||||||||||||||
| showUsage bool | ||||||||||||||||||||||||||
| globalUsage *usage.GlobalUsage | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| // Game state (cached for display) | ||||||||||||||||||||||||||
| apm int | ||||||||||||||||||||||||||
| streakMult float64 | ||||||||||||||||||||||||||
|
|
@@ -524,10 +529,11 @@ func (m *Model) handleKey(msg tea.KeyMsg) tea.Cmd { | |||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| // Handle overlays first | ||||||||||||||||||||||||||
| if m.showHelp || m.showStats || m.showActivity { | ||||||||||||||||||||||||||
| if m.showHelp || m.showStats || m.showActivity || m.showUsage { | ||||||||||||||||||||||||||
| m.showHelp = false | ||||||||||||||||||||||||||
| m.showStats = false | ||||||||||||||||||||||||||
| m.showActivity = false | ||||||||||||||||||||||||||
| m.showUsage = false | ||||||||||||||||||||||||||
| return nil | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
|
|
@@ -563,6 +569,13 @@ func (m *Model) handleKey(msg tea.KeyMsg) tea.Cmd { | |||||||||||||||||||||||||
| case "s": | ||||||||||||||||||||||||||
| m.showStats = true | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| case "u": | ||||||||||||||||||||||||||
| m.showUsage = true | ||||||||||||||||||||||||||
| go func() { | ||||||||||||||||||||||||||
| global, _ := usage.GetGlobalUsage() | ||||||||||||||||||||||||||
| m.globalUsage = global | ||||||||||||||||||||||||||
| }() | ||||||||||||||||||||||||||
|
Comment on lines
+572
to
+577
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. logic: Race condition: the goroutine updates
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: internal/tui/model.go
Line: 572:577
Comment:
**logic:** Race condition: the goroutine updates `m.globalUsage` without synchronization while the UI reads it in `viewUsageOverlay()` on line 736-741 of view.go. This can cause data races.
```suggestion
case "u":
m.showUsage = true
return tea.Cmd(func() tea.Msg {
global, _ := usage.GetGlobalUsage()
return messages.UsageLoaded{Usage: global}
})
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| case "up", "k": | ||||||||||||||||||||||||||
| if len(m.sessions) > 0 { | ||||||||||||||||||||||||||
| session := m.sessions[m.selected] | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Overly broad pattern: the
regexp.MustCompile(\thinking`)` pattern on line 83 will match any text containing "thinking" (e.g., "I'm thinking about the problem" in user input). This is too broad and will cause false positives. The case-insensitive patterns on lines 74-76 already cover thinking states properly.Was the standalone "thinking" pattern intentional for matching lowercase thinking states without punctuation?
Prompt To Fix With AI