Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 536e53c789
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pythonApi: PythonApiSchema.optional().describe( | ||
| "Python API framework (django-rest-framework, django-ninja)", | ||
| ), |
There was a problem hiding this comment.
Reject non-Django Python API selections
This exposes --python-api for every Python scaffold, but the CLI validation path (validateFullConfig) does not call the new analyzeStackCompatibility adjustment, so --ecosystem python --python-web-framework fastapi --python-api django-ninja is accepted. The templates and dependency entries only emit DRF/Ninja under Django guards, while the README/AI docs still report the selected API, leaving a scaffold that claims a feature it did not generate; please reject or coerce this flag unless the selected web framework is Django.
Useful? React with 👍 / 👎.
495d562 to
00a4802
Compare
00a4802 to
d8aea84
Compare
d8aea84 to
51ecf22
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afe9dbb51f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {{#if (eq caching "upstash-redis")}} | ||
| # Upstash Redis via Redis protocol | ||
| redis = { version = "1.2.1", features = ["tokio-comp"] } |
There was a problem hiding this comment.
Avoid emitting duplicate Redis workspace dependencies
When a Rust project selects both shared Upstash caching and the Rust Redis cache (--ecosystem rust --caching upstash-redis --rust-caching redis), this new block emits a redis entry in [workspace.dependencies] and the existing rustCaching === "redis" block later in the same file emits another redis entry with a different version. Cargo/TOML rejects duplicate keys before the generated app can build, so these two selections need to share a single dependency definition or be made mutually exclusive.
Useful? React with 👍 / 👎.
Summary
Added Tools
TypeScript UI and shadcn
Python
Rust
Go
Java
Validation
Notes