fix: resolve idempotency middleware and health check issues - #1
Open
MatanOga01 wants to merge 1 commit into
Open
fix: resolve idempotency middleware and health check issues#1MatanOga01 wants to merge 1 commit into
MatanOga01 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves all issues assigned to MatanOga01:
Closes
Changes
ApexChainx#312 — Idempotency middleware no longer caches error responses
ApexChainx#313 — Idempotency keys are now scoped per user
idempotency:{actor_key}:{idempotency_key}Idempotency-KeyApexChainx#314 — Idempotency middleware no longer 500s when Redis is down
ApexChainx#315 — Health check now catches the correct exception type
check_database()/check_celery()helpers fromapp/main.pythat incorrectly caughtredis.ConnectionErroraround a Postgres probe/health/readinessendpoint already usesbuild_readiness_report()inhealth_report.pywhich catchessqlalchemy.exc.OperationalErrorcorrectlyFiles changed
app/middleware/idempotency.pyapp/main.py