feat: cross-platform support (Windows, macOS scaffolding)#1
Merged
Conversation
Matbe34
force-pushed
the
feature/windows-support
branch
from
May 4, 2026 19:24
37d5ab2 to
63f096d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the Linux-only signature/PDF code into per-OS implementations via Go build tags, introduces two new packages (
internal/signature/{certstore,platform}), wires Windows certificate-store signing throughgithub/smimesign/certstore, and adds CI verification onwindows-latest.All Go code is now portable across Linux / Windows / macOS. Linux behavior is unchanged. macOS Keychain is stubbed (returns "not implemented"); Windows certificate store is functional via the new certstore abstraction.
Notable changes
*_linux.go/*_windows.go/*_darwin.gobuild tags acrossinternal/signature/{certificates,signing,nss},internal/signature/platform/, andinternal/pdf/render_suppress_*.internal/signature/certstorepackage abstracts platform certificate stores behind a single `CertificateStore` interface (`ListCertificates`, `GetSigner` returning both signer and `*x509.Certificate`, `Close`). Linux backend wraps NSS; Windows backend wraps smimesign.Test plan
Follow-ups (out of scope, worth tracking)