SS-453 Azdls custom creds - #9
Merged
Merged
Conversation
Needed so that the ADLS backend can accept a custom credential provider:
`AzdlsBuilder::credential_provider_chain` landed in opendal-service-azdls
0.59.1, and 0.57 offers no way to reach the signer.
Note that ADLS *replaces* the provider chain, the way S3 does, rather than
prepending to it the way GCS does, so an ADLS loader needs no equivalent of
`suppress_default_credential_sources`.
Two breaking changes come with the bump:
* `Operator::new`/`from_config` return the operator directly, so the
trailing `.finish()` is gone from all seven construction sites.
* The HTTP transport is opt-in as of 0.59 (opendal RFC 7749). Without one,
every request to an HTTP-backed service fails at call time with
`ConfigInvalid` rather than failing to build, which showed up as the Glue
schema-update tests failing to write table metadata. The workspace now
enables `http-transport-reqwest` and `create_operator` installs the
default transport behind a `Once`, rather than relying on opendal's
pre-`main` constructor, which its own documentation warns linkers may drop
when opendal is linked as a `staticlib` for the Python bindings.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
patrickwwbutler
requested review from
DAlperin,
martykulma,
peterdukelarsen and
ublubu
September 10, 2026 21:07
martykulma
approved these changes
Sep 16, 2026
martykulma
left a comment
martykulma
left a comment
There was a problem hiding this comment.
There's a doc string that could use an update, and may want to updated DEPENDENCIES.rust.tsv, but otherwise lgtm. Thanks @patrickwwbutler!
Docker Hub no longer serves the MinIO server and client repositories, preventing integration test containers from starting. Use the corresponding Quay images with the existing release tags. Generated-by: Codex Co-authored-by: Kevin Liu <kevinjqliu@users.noreply.github.com>
patrickwwbutler
added a commit
to MaterializeInc/materialize
that referenced
this pull request
Sep 16, 2026
…rg catalogs backed by Azure Data Lake Storage (V2) (#38893) Implements the `VendedCredential` trait for the newly created `CustomAzdlsCredentialLoader` added to the MZ iceberg-rust fork in MaterializeInc/iceberg-rust#9 Then plugs in a `CustomAzdlsCredentialLoader` with the previously created `VendedCredentialLoader` using this trait implementation into the `OpenDalStorageFactory::Azdls` constructor, allowing opendal to call it for fresh vended credentials from the catalog. Tested manually in our Azure Databricks workspace, with optimistic plans to add CI testing later on. Also closes [SS-173](https://linear.app/materializeinc/issue/SS-173)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SS-453 by adding support for a custom credential loader to
OpenDalStorage::Azdls, which attaches a custom credential loader to the credential chain in the storage operator.Also bumps
opendalcrate version to0.59to get the recently added support for a credential chain in theAzdlsBuilder.This will then be followed up in materialize by implementing
VendedCredentialforAzdlsCredentialand building aVendedCredentialLoader<AzdlsCredential>and plugging it into theOpenDalStorageBuilder.