Fix formula text truncated on XML character references

[sentinelt]

Summary

dataValidation / formula character data that contains XML numeric character references (e.g. – for an en-dash) was truncated when reading .xlsx files.

Root cause

quick-xml emits those references as Event::GeneralRef nodes between successive Event::Text fragments. The parsers for DataValidation (formula1 / formula2) and Formula replaced the accumulator on each Text event and ignored GeneralRef, so only the last text fragment survived.

Example list formula in a real workbook:

<formula1>"0&#8211;3 years ago,4&#8211;5 years ago,6&#8211;7 years ago"</formula1>

was read as:

7 years ago"

instead of the full list string.

Fix

• Append successive Text events instead of overwriting
• Resolve and append GeneralRef (numeric char refs + common named entities)
• Shared helpers: append_xml_text / append_xml_general_ref
• Unit tests covering en-dash list formulas and plain list formulas
• Close a missing brace in number_formater tests that broke compilation of the local tree

[MathNya]

@sentinelt
Thank you for the PR.
Since there were no issues with the changes, I’ll go ahead and merge them.
(I’ll make a few minor adjustments after merging.)

There are a few other instances of this, so it looks like we’ll need to review the entire code.

[c-git]

@MathNya after you've done the update in the other places as well, please let me know so I can test if it also fixes my issue in #336

[MathNya]

@c-git
We have addressed all the issues.
Please check #336.

[c-git]

Thank you. I can confirm this fixed my problem. Sorry I never got time to work on it. Been under pressure.

PS. The hash of the output xlsx file has changed but I wasn't able to easily find the difference. It still has the some contents when saved as csv. I recall there was a tool you used to compare the files but I can't recall what it was and can't remember in which pr or issue you'd spoken about it. Would you mind sharing the tool again so I can look into what changed in the file please.

[c-git]

FYI I extracted the xml from the zip, pretty printed it, and diffed it in vscode and found the change. It was to a column width. Would still love to know what tool you use cuz I'm sure that would have been faster but just FYI since I mentioned that something changed just reporting back.

[MathNya]

@c-git
Thank you for your prompt response.

I’m currently using this VSCode extension to check XML.
https://marketplace.visualstudio.com/items?itemName=yuenm18.ooxml-viewer

(There used to be a very user-friendly Google Chrome extension, but it’s now deprecated and can no longer be used.)

[c-git]

I’m currently using this VSCode extension to check XML. https://marketplace.visualstudio.com/items?itemName=yuenm18.ooxml-viewer

Thank you very much