Fix JSON parse error: NoMemory and JSON parse error: EmptyInput when fetching large adsb payload. - #21
Open
SmokedSeaSalt wants to merge 8 commits into
Open
Fix JSON parse error: NoMemory and JSON parse error: EmptyInput when fetching large adsb payload.#21SmokedSeaSalt wants to merge 8 commits into
SmokedSeaSalt wants to merge 8 commits into
Conversation
Optimize plane parsing
Reduce heap usage
1 format fix, 1 extra http.end() in error path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when getting a big payload the heap would fill up and cause the JSON parser to fail.
this would result in error: NoMemory and JSON parse error: EmptyInput.
By changing the JSON parser to take the http stream it can directly parse the data without having to store it in a big buffer first.
By implementing a filter only the nodes actually used will get stored to save space on the heap.
Added a check if enough heap is available and if not skip this current fetch.
This is my first time contributing to another project. Feedback is welcome!