Fix build against LovyanGFX >= 1.2.x: drop redundant fonts alias - #60
Open
ps915 wants to merge 1 commit into
Open
Fix build against LovyanGFX >= 1.2.x: drop redundant fonts alias#60ps915 wants to merge 1 commit into
ps915 wants to merge 1 commit into
Conversation
LovyanGFX declares a global `namespace fonts` and a `using namespace fonts;`
in lgfx/v1/lgfx_fonts.hpp. The `namespace fonts = lgfx::v1::fonts;` alias in
three translation units collides with it:
error: 'namespace fonts = lgfx::v1::lgfx::v1::fonts;'
conflicts with a previous declaration
The alias is redundant now that the library exposes `fonts` globally, so
remove it rather than pinning the dependency backwards.
CI does not catch this: the cache key falls back to restore-keys
`${{ runner.os }}-pio-`, restoring a libdeps tree whose older LovyanGFX still
satisfies `^1.2.7`. A fresh checkout resolves 1.2.25 and fails to compile.
Verified: pio run -e supermini succeeds (RAM 15.5%, Flash 39.4%).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LovyanGFX declares a global
namespace fontsand ausing namespace fonts;in lgfx/v1/lgfx_fonts.hpp. Thenamespace fonts = lgfx::v1::fonts;alias in three translation units collides with it:The alias is redundant now that the library exposes
fontsglobally, so remove it rather than pinning the dependency backwards.CI does not catch this: the cache key falls back to restore-keys
${{ runner.os }}-pio-, restoring a libdeps tree whose older LovyanGFX still satisfies^1.2.7. A fresh checkout resolves 1.2.25 and fails to compile.Verified: pio run -e supermini succeeds (RAM 15.5%, Flash 39.4%).