Skip to content

Fix module reload failure when calling update from within module #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
visschersm merged 2 commits into from
Oct 30, 2025
Merged

Fix module reload failure when calling update from within module #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b554e4c
Initial plan
Copilot Oct 30, 2025
8123681
Fix module reload issue by removing Remove-Module calls
Copilot Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions private/Update-QuickPath.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ function Update-QuickPath {
function Update-QuickPathFromGallery {
try {
$moduleName = "quickpath"
if (Get-Module $moduleName) {
Remove-Module $moduleName -Force -ErrorAction SilentlyContinue
}
Update-Module -Name $moduleName -Force -ErrorAction Stop
Import-Module $moduleName -Force -ErrorAction Stop
Write-Host "$moduleName updated from gallery and reloaded." -ForegroundColor Green
Expand All @@ -37,10 +34,6 @@ function Update-QuickPathFromBuild {
Write-Warning "Built quickpath module not found at '$quickPathManifest'. Please run 'Invoke-Build Build' first."
return
}

if (Get-Module $moduleName) {
Remove-Module $moduleName -Force -ErrorAction SilentlyContinue
}

Import-Module $quickPathManifest -Force -ErrorAction Stop
Write-Host "$moduleName has been built, tested, and reloaded." -ForegroundColor Green
Expand Down
12 changes: 5 additions & 7 deletions tests/Update-QuickPath.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Context 'Update-QuickPath' {
. $PSScriptRoot\..\private\Update-QuickPath.ps1
}
BeforeEach {
Mock Remove-Module
Mock Update-Module
Mock Import-Module
}
Expand Down Expand Up @@ -42,17 +41,16 @@ Context 'Update-QuickPath' {

Assert-MockCalled -CommandName Write-Error -Times 1 -Exactly -Scope It
}
It 'Should remove existing module before updating from gallery' {
Mock Get-Module { @{ Name = "quickpath" } }
It 'Should reload module after updating from gallery' {
Update-QuickPath -FromGallery

Assert-MockCalled -CommandName Remove-Module -ParameterFilter { $Name -eq "quickpath" } -Times 1 -Exactly -Scope It
Assert-MockCalled -CommandName Update-Module -ParameterFilter { $Name -eq "quickpath" } -Times 1 -Exactly -Scope It
Assert-MockCalled -CommandName Import-Module -ParameterFilter { $Name -eq "quickpath" } -Times 1 -Exactly -Scope It
}
It 'Should remove existing module before updating from build' {
Mock Get-Module { @{ Name = "quickpath" } }
It 'Should reload module after updating from build' {
Mock Test-Path { $true }
Update-QuickPathFromBuild

Assert-MockCalled -CommandName Remove-Module -ParameterFilter { $Name -eq "quickpath" } -Times 1 -Exactly -Scope It
Assert-MockCalled -CommandName Import-Module -Times 1 -Exactly -Scope It
}
}