Upgrade Specta 2.0.0-rc.23#58
Conversation
| export_config.format(path).context( | ||
| "Failed to format exported bindings, make sure you have the correct formatter installed", | ||
| )?; | ||
| // export_config.format(path).context( |
There was a problem hiding this comment.
I have removed the Specta formatter from main.
I would concider bring it back but the main reason behind removing it is that it's extra API surface for what can easily be written as a Command that is run after the export process. It can also be very environment dependant for monorepo's so the default setup wouldn't always suffice.
This could possibly be brought into TauRPC/Tauri Specta/rspc without being in Specta's core. Happy for you to straight up copy the old code.
# Conflicts: # example/src-tauri/Cargo.lock # taurpc/Cargo.toml # taurpc/src/lib.rs
oscartbeaumont
left a comment
oscartbeaumont
left a comment
There was a problem hiding this comment.
Okay this is ready for review. I am happy to hold of merging until the Specta release is ready! I am hoping to take it within the next 2 weeks max so it won't be long.
|
I am closing this in favor of #64 |
2 participants
This is a wip for upgrading TauRPC for the next Specta version (which is still a work in progress).
For now this is mostly for my personal reference as I want to ensure a lot of the upstream breaking changes don't cause issues.
Most of the PR comments are for later me so feel free to ignore this until it's no longer a draft!