Skip to content

fix: fail a run that lints nothing, and say so - #318

Open
MaximeGaudin wants to merge 2 commits into
mainfrom
fix/issue-118-zero-skills-silent-success
Open

MaximeGaudin wants to merge 2 commits into
mainfrom
fix/issue-118-zero-skills-silent-success

Conversation

@MaximeGaudin

@MaximeGaudin MaximeGaudin commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Summary

  • An empty directory, a typo'd path, or a plain non-skill file all produced the identical "Nothing to report" success line and exit 0 — a CI job pointed at the wrong directory passed forever, indistinguishable from a clean run.
  • A run that discovers no SKILL.md files now fails the way a missing path already does, naming the paths it looked under.

Fixes #118
Also resolves #36 (a non-skill file argument exited 0 with no diagnostic).

Test plan

  • New regression test failed before the fix (exit 0 + clean-pass line on an empty dir and a plain file)
  • New regression test passes after the fix (exit 3, distinct message on stderr, no clean-pass line)
  • Local checks mirror CI and passed before push
  • CI green on the PR

An empty directory, a typo'd path, or a plain non-skill file all produced the identical 'Nothing to report' success line and exit 0, so a CI job pointed at the wrong directory passed forever. A run that discovers no SKILL.md files now fails the way a missing path already does, naming the paths it looked under. Also resolves #36 (a non-skill file argument exited 0 with no diagnostic).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant