fix: Fix the storage of sanitized project name - EXO-86231#599
Merged
Conversation
boubaker
reviewed
May 7, 2026
Prior to this change, when creating or editing a task project, a JavaScript payload inserted in the name field could be executed when the task project is deleted, leading to an XSS vulnerability, this is already fixed with a previous commit by storing a sanitized project name which is not coherent with the architectural choice made is: Sanitize OnRead from DB and not altering data OnWrite on DB. After this commit, we ensure to sanitize the project name only when displaying the delete confirmation popup and not when storing projects. Resolves Meeds-io/si#11
|
rdenarie
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, when creating or editing a task project, a JavaScript payload inserted in the name field could be executed when the task project is deleted, leading to an XSS vulnerability, this is already fixed with a previous commit by storing a sanitized project name which is not coherent with the architectural choice made is: Sanitize OnRead from DB and not altering data OnWrite on DB. After this commit, we ensure to sanitize the project name only when getting projects and not when storing them.
Resolves Meeds-io/si#11