fix(memory): add dedicated SGLang and vLLM thinking transports - #348
Open
LeslieWylie wants to merge 1 commit into
Open
fix(memory): add dedicated SGLang and vLLM thinking transports#348LeslieWylie wants to merge 1 commit into
LeslieWylie wants to merge 1 commit into
Conversation
Route Qwen enable_thinking through chat_template_kwargs only for explicit sglang and vllm providers. Keep the generic OpenAI-compatible request body unchanged so cloud-provider calls retain their existing contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #312 with a clean branch history.
Add dedicated
sglangandvllmmemory LLM providers for the Qwenchat_template_kwargs.enable_thinkingtransport.The generic
openai_compatibleprovider keeps its existing top-level request shape, so cloud-provider calls are unaffected.Changes
sglangandvllmas explicit LLM provider valuesenable_thinkingintochat_template_kwargsonly for those dedicated providerschat_template_kwargs, including an explicitenable_thinkingoverrideenable_thinkingbehavior unchanged for DashScope and generic OpenAI-compatible endpointsValidation
vitest run Memory/tests/llm-thinking.test.ts— 21 tests passedenable_thinking=falsewas ignored whilechat_template_kwargs.enable_thinking=falseproduced zero reasoning tokens and valid JSON