Skip to content

Code Review #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michelledlee wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Code Review #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70231d3
Code review
michelledlee Apr 13, 2019
8a90ba4
Merge pull request #1 from michelledlee/michelledlee-patch-1
michelledlee Apr 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion imports/ui/GameRoom.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { Cards } from "../api/cards.js";
import { paginate } from "../utils/paginate";
import { random } from "../utils/random";

// I think there's some issue with an exit button not being available in the middle of the game and players being trapped - perhaps an update to the UI with a button that is always there would be helfpul

class GameRoom extends Component {
constructor(props) {
Expand Down Expand Up @@ -296,4 +297,4 @@ export default withTracker(() => {
cards: Cards.find({}).fetch(),
ready : handle.ready() && handle2.ready()
};
})(GameRoom);
})(GameRoom);