Create cut functions automatically based on the design object #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thank you, @yihui!
2 minor comments:
- If
sim_gs_n(original_design = x, cut = NULL, ...), we will setcut = auto_cut(x)inside ofsim_gs_n. - Shall we name
auto_cutintocut_from_design? I am not good at naming, so I will defer to you, John and Nan's suggestions!
yihui
commented
Nov 4, 2025
Collaborator
Author
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
Both changes are done now.
jdblischak
approved these changes
Nov 6, 2025
Collaborator
jdblischak
left a comment
jdblischak
left a comment
There was a problem hiding this comment.
Should we add an example and/or test?
Collaborator
Author
I don't have an opinion. @LittleBeannie What do you think? |
[ci skip]
LittleBeannie
approved these changes
Nov 13, 2025
Collaborator
LittleBeannie
left a comment
LittleBeannie
left a comment
There was a problem hiding this comment.
Thank you, @yihui!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to abstract away the tedious boilerplate code in https://github.com/keaven/gsDesign2Shiny/issues/38 to create cut functions with a simple shortcut, i.e.,
cut = "auto".I don't really understand the stats terminologies here, and would like to hear your suggestion on the name of this shortcut (
"auto"is just my arbitrary choice).