Improve fresh local setup flow#793
Open
nsteve-one wants to merge 1 commit into
Open
Conversation
Contributor
|
@nstevensbscales is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
3f8809d to
6318616
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #597
Summary
This makes the documented fresh-clone path work from the repo root:
What I found
On current
master, a fresh local run failed after Docker and the router server started becauseecho-controlran Prisma without a localDATABASE_URL:The README also sent new contributors straight to
pnpm iwithout listing the required tools, and one workspace example printed annpm dedupe/workspace:*error duringpnpm i.Changes
echo-controllocal setup automatically before rootpnpm dev.packages/app/control/scripts/setup.shso it creates.envfrom.env.example, fills an emptyAUTH_SECRET, and ensures the local Docker PostgreSQLDATABASE_URLis present without overwriting populated values.npm dedupepostinstall command when thenext-402-chatworkspace example is being installed by pnpm, removing the scary but ignoredworkspace:*install error.Verification
npx -y pnpm@10.11.0 installnpx -y pnpm@10.11.0 devcurl -I http://localhost:3000returnedHTTP/1.1 200 OKcurl http://localhost:3069/healthreturned{"status":"healthy", ...}npx -y pnpm@10.11.0 -C packages/sdk/examples/next-402-chat run postinstallnpx -y pnpm@10.11.0 exec prettier --check README.md package.json packages/sdk/examples/next-402-chat/package.jsonbash -n packages/app/control/scripts/setup.shgit diff --check